Dialog does not load in template_spa example

[jkriesel]

When I try to load a dialog with the current release I get this error:

ype '_MaterialDialogComponent' is not a subtype of type 'bool' of 'boolean expression' where _MaterialDialogComponent is from package:mdl/mdldialog.dart bool is from dart:core

0 MaterialModel.attached (package:mdl/src/directive/components/MaterialModel.dart:63:24)

1 DomRenderer._callAttached. (package:mdl/src/application/modules/DomRenderer.dart:201:31)

2 List.forEach (dart:core-patch/growable_array.dart:254)

3 DomRenderer._callAttached (package:mdl/src/application/modules/DomRenderer.dart:198:38)

4 DomRenderer._callAttached. (package:mdl/src/application/modules/DomRenderer.dart:210:13)

5 Object&ListMixin.forEach (dart:collection/list.dart:63)

6 DomRenderer._callAttached (package:mdl/src/application/modules/DomRenderer.dart:209:26)

7 DomRenderer._callAttached. (package:mdl/src/application/modules/DomRenderer.dart:210:13)

8 Object&ListMixin.forEach (dart:collection/list.dart:63)

9 DomRenderer._callAttached (package:mdl/src/application/modules/DomRenderer.dart:209:26)

10 DomRenderer._callAttached. (package:mdl/src/application/modules/DomRenderer.dart:210:13)

11 Object&ListMixin.forEach (dart:collection/list.dart:63)

12 DomRenderer._callAttached (package:mdl/src/application/modules/DomRenderer.dart:209:26)

13 DomRenderer._callAttached. (package:mdl/src/application/modules/DomRenderer.dart:210:13)

14 Object&ListMixin.forEach (dart:collection/list.dart:63)

15 DomRenderer._callAttached (package:mdl/src/application/modules/DomRenderer.dart:209:26)

16 DomRenderer.render... (package:mdl/src/application/modules/DomRenderer.dart:92:25)

[jkriesel]

The line of code at MaterialModel.dart:63:24 literally cannot execute as it appears to be missing a set of parenthesis and will error literally every time it is executed. What's the best way for me to submit changes? Should I just do it through git or would you like the changes some other way?

[MikeMitterer]

Hi, thanks for your report!

I would prefere a PR on GH if possible. I'll check it in asap.

Regards

Mike

Am 05.12.16 um 03:18 schrieb jkriesel:

The line of code at MaterialModel.dart:63:24 literally cannot execute as it appears to be missing a set of parenthesis and will error literally every time it is executed. What's the best way for me to submit changes? Should I just do it through git or would you like the changes some other way?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MikeMitterer/dart-material-design-lite/issues/39#issuecomment-264753381, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHHrldgfEEfxrXY2BNS33ABnYarvQNdks5rE3RngaJpZM4LDuGB.

-- Michael Mitterer, IT-Consulting and Development Limited, Niederlassung Österreich Dorfstraße 112 A-6363 Westendorf, Tirol Firmenbuchnummer: FN382753y UID: ATU67431503

Tel: +43 5334 8899 Mobil: +43 676 6319899 Skype: mike.mitterer office@mikemitterer.at www.mikemitterer.at

Für topaktuelle Infos folgen Sie mir bitte auf Google+: http://googleplus.mikemitterer.at/

oder auf Twitter: http://twitter.mikemitterer.at/

natürlich auch auf FaceBook http://facebook.mikemitterer.at/

und auf YouTube http://youtube.mikemitterer.at/

---

Auskünfte und Angebote per eMail sind freibleibend und unverbindlich.

Die geltenden AGB finden Sie unter folgendem Link: http://www.mikemitterer.at/kontakt/impressum/agb/

---

Diese Email wurde digital signiert, somit wird sichergestellt, dass diese Email auch von dem Absender stammt, den Sie erwarten. Bitte prüfen Sie die Gültigkeit dieser Unterschrift. Vertrauen Sie keinem Inhalt den Sie von dieser Emailadresse (office@mikemitterer.at) erhalten ohne gültige Unterschrift - Zu Ihrer eigenen Sicherheit.

[x] Bitte denken Sie an die Umwelt bevor Sie diese eMail drucken!

[jkriesel]

Hi Mike,

Added pull request #40. Thank you for sharing this code base with the world. It's very, very well done.

Sincerely,

Jason

[jkriesel]

Hi Mike,

I also made one other change that is critically important. Adding the IS_UPGRADED class is critical.

• element.classes.add(_cssClasses.IS_UPGRADED);

The odd part of it is that without that line it will work fine in Chromimum, but your dialogs will not bind correctly in Chrome. It's a very confusing issue, but I believe it's fixed correctly. I'm currently setting my pubspec file to look for the library locally, but would prefer to use a release version in the future. Let me know if you have any questions.

Thanks again,

Jason Kriesel

[MikeMitterer]

Many Thanks! :clap: