search

MikeNGarrett / rcm

Provide a way for volunteers to create and update rescue cases.
Other
5 stars 7 forks source link

Responsive design #7

Open MikeNGarrett opened 11 years ago

MikeNGarrett commented 11 years ago

Most of the responsiveness is handled already. We need a mobile-friendly menu, a couple breakpoint changes (what if we get rid of the table markup for smaller screens?) and some QA on various devices.

twerptwo commented 11 years ago

Can we please use the SCSS version of bones? It's much easier to work with than plain old CSS.

MikeNGarrett commented 11 years ago

I picked css because it's more universal to work with when you have people from a variety of different backgrounds. I can't justify working with a preprocessor in this case even though that's the way I prefer to work.

twerptwo commented 11 years ago

What are the odds of someone willing to do all this work but won't put up with a preprocessor?

MikeNGarrett commented 11 years ago

Odds are high as I'm the one that's willing to do the work and not willing to put up with a preprocessor.

Look, I really appreciate the argument you're making, but the barrier of entry to contribute to this project has to be as low as possible.

If you would like to use sass or scss please feel free to do so and upload the css or create a branch where these files exist. Just realize that someone may come along that doesn't know any better and overwrite the css and cause a lot of headaches.

abelq commented 10 years ago

hi Mike, Is someone working on making the menu responsive? I could pitch in.

MikeNGarrett commented 10 years ago

No one is doing it yet. Definitely needs to be done. Your help would be greatly appreciated.

I would love to see something like this: http://responsive-nav.com/ as far as functionality. It doesn't have to use that plugin, though.

kjpro27 commented 10 years ago

I'll try take a look tonight.

On Mon, Nov 25, 2013 at 1:46 PM, Mike Garrett notifications@github.comwrote:

No one is doing it yet. Definitely needs to be done. Your help would be greatly appreciated.

I would love to see something like this: http://responsive-nav.com/ as far as functionality. It doesn't have to use that plugin, though.

— Reply to this email directly or view it on GitHubhttps://github.com/MikeNGarrett/rcm/issues/7#issuecomment-29229541 .

MikeNGarrett commented 10 years ago

@kjpro27 can you work with @abelq and see what needs to be done?

kjpro27 commented 10 years ago

Yeah, I'm looking into it now.

Sent from my iPad

On Nov 25, 2013, at 9:30 PM, Mike Garrett notifications@github.com wrote:

@kjpro27 can you work with @abelq and see what needs to be done?

— Reply to this email directly or view it on GitHub.

wass3r commented 10 years ago

@kjpro27 submitted https://github.com/MikeNGarrett/rcm/pull/34 and I merged. Anything else needed for this issue? Also, thanks @kjpro27 !

wass3r commented 10 years ago

It might need some styling love, but that could be a separate ticket? (I only see a hyperlink when I hit that breakpoint)

kjpro27 commented 10 years ago

Yeah, I wasn't sure if we wanted to make a hamburger button or something a little nicer looking so I just left it at the default for now.