search

MikePopoloski / SharpBgfx

C# bindings for the bgfx graphics library
MIT License
169 stars 30 forks source link

Fixed bgfx_create_frame_buffer_from_nwh args and minor changes. #30

Closed EugenyN closed 5 years ago

EugenyN commented 5 years ago

Hello. Please see my bgfx_create_frame_buffer_from_nwh args fix

EugenyN commented 5 years ago

Thanks for the review. I added one more commit.

EugenyN commented 5 years ago

it seems there is also another issue: TextureFlags is outdated. New flags have been added to the native bgfx. (BGFXTEXTURE and BGFXSAMPLER) Unfortunately now I don’t have time to see this in more detail.

MikePopoloski commented 5 years ago

I took a look and I believe all of the texture flags are still there. He renamed some of the constants to be BGFXSAMPLER* but they kept the same values and are used in the same way.

EugenyN commented 5 years ago

I took a look and I believe all of the texture flags are still there. He renamed some of the constants to be BGFXSAMPLER* but they kept the same values and are used in the same way.

Yes. you're right. I looked more attentively, _MASK _SHIFT used for bitwise operations and are not ordinary flags.