search

MikePopoloski / SharpBgfx

C# bindings for the bgfx graphics library
MIT License
169 stars 30 forks source link

Add Getter/Setter for MaxEncoders & Rename bgfx_begin/end to match ne… #32

Closed billfreist closed 2 years ago

billfreist commented 5 years ago

…wer BGFX versions

Added a getter/setter for the MaxEncoders value, which is required if you want to do threaded rendering.

Newer versions of BGFX renamed bgfx_begin/end to bgfx_encoder_begin/end. I'm on a custom build of BGFX so this is causing a conflict for me, so I figure I would push this change to you (which would also require an update to the one hosted here)

MikePopoloski commented 5 years ago

Thanks for the PR Bill. I've been waiting for genie to add support for VS2019 before updating to the latest bgfx changes (I basically can't build the native lib right now). I don't want to pull in just the one pinvoke change on its own until I can test the whole set of changes together. I'll be sure to pull in the MaxEncoders stuff once I do though.

billfreist commented 5 years ago

Sounds good, just sent Branimir a PR which adds VS2019 support. He'll likely merge it sometime today, I just messaged him.

https://github.com/bkaradzic/GENie/pull/439