Closed KennethDRoe closed 2 weeks ago
MikePopoloski
commented
4 weeks ago Thanks for the PR. In case it wasn't clear, I can't land this until the tests are fixed.
Also I think this output should be hidden behind a command line flag. The JSON output is already very large for real world designs, and this will make it much larger. I suspect many people won't want to see this in the output, so it should be controlled via the flag.
KennethDRoe
commented
4 weeks ago I’ll add a flag and fix the tests. It make a few days. - KenSent from my iPhoneOn May 29, 2024, at 8:43 PM, Michael Popoloski @.***> wrote: Thanks for the PR. In case it wasn't clear, I can't land this until the tests are fixed. Also I think this output should be hidden behind a command line flag. The JSON output is already very large for real world designs, and this will make it much larger. I suspect many people won't want to see this in the output, so it should be controlled via the flag.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
codecov[bot]
commented
3 weeks ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.70%. Comparing base (
a4d08eb) to head (27e3657).
MikePopoloski
commented
2 weeks ago It seems that the tests are still failing in the CI build. Also I got access to a Macbook M3 and the tests all pass locally there, so I'm not sure why you're unable to get them to pass on your machine unless the problem is specific to the M1s.
KennethDRoe
commented
2 weeks ago The failures on my machine may be due to the software stack (and not the M1 processor).
Can you send over the list of failures you are seeing with my pull request? Also, make sure you have the latest version of files from my fork. I made a couple of last minute fixes.
- KenOn Sun, Jun 9, 2024 at 10:53 PM Michael Popoloski @.***> wrote:
It seems that the tests are still failing in the CI build. Also I got access to a Macbook M3 and the tests all pass locally there, so I'm not sure why you're unable to get them to pass on your machine unless the problem is specific to the M1s.
— Reply to this email directly, view it on GitHub https://github.com/MikePopoloski/slang/pull/1011#issuecomment-2156663693, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIIJFIPNXN4RIZTXJ6HGQ3LZGR26RAVCNFSM6AAAAABIJVMH3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGY3DGNRZGM . You are receiving this because you authored the thread.Message ID: @.***>
MikePopoloski
commented
2 weeks ago The CI results are on this thread of the PR. For example: https://github.com/MikePopoloski/slang/actions/runs/9364528795/job/25888520547?pr=1011
KennethDRoe
commented
2 weeks ago I believe I fixed the one failing test. Try again.
- KenOn Tue, Jun 11, 2024 at 5:38 AM Michael Popoloski @.***> wrote:
The CI results are on this thread of the PR. For example: https://github.com/MikePopoloski/slang/actions/runs/9364528795/job/25888520547?pr=1011
— Reply to this email directly, view it on GitHub https://github.com/MikePopoloski/slang/pull/1011#issuecomment-2159425985, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIIJFIOWRS5SPGMKG6GNMZTZGYTEVAVCNFSM6AAAAABIJVMH3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGQZDKOJYGU . You are receiving this because you authored the thread.Message ID: @.***>
I think that having source file/line info in the json outputs will be useful to the community as a whole. I'm submitting a pull request to contribute this change.