MikePopoloski / slang

SystemVerilog compiler and language services
MIT License
558 stars 122 forks source link

[slang] Fix bug with SignalEventControl iff clause emitting. #1019

Closed likeamahoney closed 3 weeks ago

likeamahoney commented 3 weeks ago

There is copypasta bug with SignalEventControl iffCondition emitting during it's AST constructing. Right hand of iff was constructed from left hand part.

And I also added support for iffCondition serializing.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.23%. Comparing base (04dedf0) to head (38fe37e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019/graphs/tree.svg?width=650&height=150&src=pr&token=sS5JjK9091&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski)](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) ```diff @@ Coverage Diff @@ ## master #1019 +/- ## ======================================= Coverage 94.22% 94.23% ======================================= Files 191 191 Lines 47552 47554 +2 ======================================= + Hits 44807 44812 +5 + Misses 2745 2742 -3 ``` | [Files](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) | Coverage Δ | | |---|---|---| | [source/ast/TimingControl.cpp](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?src=pr&el=tree&filepath=source%2Fast%2FTimingControl.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski#diff-c291cmNlL2FzdC9UaW1pbmdDb250cm9sLmNwcA==) | `90.21% <100.00%> (+0.06%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Last update [04dedf0...38fe37e](https://app.codecov.io/gh/MikePopoloski/slang/pull/1019?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski).
MikePopoloski commented 3 weeks ago

Nice, thanks for fixing.