search

MikePopoloski / slang

SystemVerilog compiler and language services
MIT License
558 stars 122 forks source link

Allow dynamic linking mimalloc #1024

Closed vivekmalneedi closed 2 weeks ago

vivekmalneedi commented 2 weeks ago

I attempted to build slang but got the following error when configuring:

CMake Error at external/CMakeLists.txt:103 (message):
  Could not find mimalloc package, min version: 2.1
Call Stack (most recent call first):
  CMakeLists.txt:173 (include)

This was because I had a dynamic library for mimalloc on my system, which cmake found, but the build is hard-coded to use the mimalloc-static target. This PR fixes the cmake configuration by choosing the dynamic mimalloc target if available.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.68%. Comparing base (1d6eb64) to head (9605523).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/MikePopoloski/slang/pull/1024/graphs/tree.svg?width=650&height=150&src=pr&token=sS5JjK9091&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski)](https://app.codecov.io/gh/MikePopoloski/slang/pull/1024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) ```diff @@ Coverage Diff @@ ## master #1024 +/- ## ======================================= Coverage 94.68% 94.68% ======================================= Files 191 191 Lines 47561 47561 ======================================= Hits 45031 45031 Misses 2530 2530 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/MikePopoloski/slang/pull/1024?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/MikePopoloski/slang/pull/1024?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Last update [1d6eb64...9605523](https://app.codecov.io/gh/MikePopoloski/slang/pull/1024?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski).