MikePopoloski / slang

SystemVerilog compiler and language services
MIT License
620 stars 138 forks source link

Don't error if multiple UDP row inputs match, unless their output differ #931

Closed udif closed 7 months ago

udif commented 7 months ago

This fixes #926 . It takes into account the 'keep previous state' output value when comparing UDP table rows. Also includes a new unit test.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.01%. Comparing base (9e15d4e) to head (1bd9f11).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/MikePopoloski/slang/pull/931/graphs/tree.svg?width=650&height=150&src=pr&token=sS5JjK9091&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski)](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) ```diff @@ Coverage Diff @@ ## master #931 +/- ## ======================================= Coverage 94.00% 94.01% ======================================= Files 189 189 Lines 48426 48440 +14 ======================================= + Hits 45525 45539 +14 Misses 2901 2901 ``` | [Files](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) | Coverage Δ | | |---|---|---| | [source/ast/symbols/MemberSymbols.cpp](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?src=pr&el=tree&filepath=source%2Fast%2Fsymbols%2FMemberSymbols.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski#diff-c291cmNlL2FzdC9zeW1ib2xzL01lbWJlclN5bWJvbHMuY3Bw) | `96.36% <100.00%> (+0.03%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Last update [9e15d4e...1bd9f11](https://app.codecov.io/gh/MikePopoloski/slang/pull/931?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Popoloski).