Closed nightblade9 closed 3 years ago
Thanks for reporting,
Can you please attache the error logs?
looks like the update is broken in general close as duplicate to #111
As workaround you have to reinstall and press cancel on the upgrade screen
I was not able to reproduce on Windows 10, can you please attache the error logs?
My steps
I was not able to reproduce on Windows 10, can you please attache the error logs?
I reproduced this yesterday on Windows 10.
I reproduced this yesterday on Windows 10.
Can you provide me the Godot log please?
Not sure what specific logs you mean - here are the ones from the Godot output window:
Godot Engine v3.3.stable.official (c) 2007-2021 Juan Linietsky, Ariel Manzur & Godot Contributors.
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Can't establish server on port 31002, error code: 22
GdUnit3: Retry (0) ...
GdUnit3: Server successfully started on port 31003
Loading GdUnit3 Plugin success
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Close all current opened scrpts ..
Unload GdUnit3 Plugin success
Update .. extracting zip ..
Update .. uninstall GdUnit3 ..
Update .. install new GdUnit3 version ..
Update .. refresh editor resources ..
core/io/image_loader.cpp:56 - Error opening file 'res://addons/gdUnit3/addons/icon.png'.
editor/editor_file_system.cpp:1817 - Error importing 'res://addons/gdUnit3/addons/icon.png'.
Cannot open file from path 'res://addons/gdUnit3/addons/icon.png.import'.
core/io/image_loader.cpp:56 - Error opening file 'res://addons/gdUnit3/icon.png'.
editor/editor_file_system.cpp:1817 - Error importing 'res://addons/gdUnit3/icon.png'.
Cannot open file from path 'res://addons/gdUnit3/icon.png.import'.
Update .. executing patches ..
Update .. enable GdUnit3 ..
core/project_settings.cpp:209 - Property not found: editor_plugins/enabled
editor/editor_node.cpp:3244 - Addon 'res://addons/gdUnit3/plugin.cfg' failed to load. No directory found. Removing from enabled plugins.
Update .. New GdUnit successfully installed
Here are the logs from the actual console window, which seem different; it's a new Godot project installed to C:\temp\errorlogs
:
Godot Engine v3.3.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
Editing project: c:/temp/errorlogs (c:::temp::errorlogs)
Godot Engine v3.3.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "CmdOption" isn't a valid type (not a script or class), or couldn't be found on base "self".
At: res://addons/gdUnit3/bin/GdUnitCmdTool.gd:121
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
At: modules/gdscript/gdscript.cpp:583
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Can't establish server on port 31002, error code: 22
GdUnit3: Retry (0) ...
GdUnit3: Server successfully started on port 31003
Loading GdUnit3 Plugin success
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Close all current opened scrpts ..
Unload GdUnit3 Plugin success
Update .. extracting zip ..
tar: Cannot connect to C: resolve failed
Update .. uninstall GdUnit3 ..
Update .. install new GdUnit3 version ..
Update .. refresh editor resources ..
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: load_image: Error opening file 'res://addons/gdUnit3/addons/icon.png'.
At: core/io/image_loader.cpp:56
ERROR: _reimport_file: Error importing 'res://addons/gdUnit3/addons/icon.png'.
At: editor/editor_file_system.cpp:1817
ERROR: Cannot open file from path 'res://addons/gdUnit3/addons/icon.png.import'.
At: editor/editor_file_system.cpp:1823
ERROR: load_image: Error opening file 'res://addons/gdUnit3/icon.png'.
At: core/io/image_loader.cpp:56
ERROR: _reimport_file: Error importing 'res://addons/gdUnit3/icon.png'.
At: editor/editor_file_system.cpp:1817
ERROR: Cannot open file from path 'res://addons/gdUnit3/icon.png.import'.
At: editor/editor_file_system.cpp:1823
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/addons/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/addons/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/addons/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
Update .. executing patches ..
Update .. enable GdUnit3 ..
WARNING: _get: Property not found: editor_plugins/enabled
At: core/project_settings.cpp:209
WARNING: set_addon_plugin_enabled: Addon 'res://addons/gdUnit3/plugin.cfg' failed to load. No directory found. Removing from enabled plugins.
At: editor/editor_node.cpp:3244
Update .. New GdUnit successfully installed
Let me know if you need anything else.
thanks for adding the logs.
Update .. extracting zip ..
tar: Cannot connect to C: resolve failed
Update .. uninstall GdUnit3 ..
Update .. install new GdUnit3 version ..
Update .. refresh editor resources ..
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/errorlogs/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
Cannot connect to C: resolve failed
. looks strange.
maybe this could be help:
https://stackoverflow.com/questions/12823499/windows-command-line-tar-cannot-connect-to-d-resolve-failed-with-chef-knife
I think you can re-close this as a duplicate of #111 , they look identical to me. If the root cause is different (different log errors), maybe you want to keep them open, it's up to you.
@nightblade9 I tested the tar command directly on windows console and get the same error, I just wondering why the OS.execute is working with the same command arguments. If you are able to check out and test https://github.com/MikeSchulze/gdUnit3/pull/115, that would help me determine if the fix works or if I need to dig deeper here.
If you are able to check out and test #115
Can you clarify how to test it? I looked through the PR and I see a comment about updating plugin.cfg
, but I also see four files changed and it looks like it's targeting main - isn't that fix for v1.0.1? How can I test updating if v0.9.7 is broken?
Hi @nightblade9 yes you only need to change the plugin.cfg to a lower version than 1.0.0. The final fix is now merged in master but it makes no difference. At least the current version taken from the plugin.cfg and is compared to the latest availabe release version (current 1.0.0)
Unless I'm missing something: running my project prompts me to upgrade gdUnit3
. Doing so still results in it wiping out all the files on disk. (I did see a newly-added update.zip
directory that I didn't see before.)
Ok this is what I expected, the fix will not work on your system. Can you please attach the new log files.
I need to deeper investigate why is working on my Windows 10 and why is failing on your Windows 10.
I see your Godot version is Godot Engine v3.3.stable.official
But the latest official downloadable version is Godot Engine v3.3.2.stable.official
I tryed on an another PC, very fresh.
I tryed also with Godot Engine v3.3.stable.official
and it works on my PC.
Interesting, i didn't notice Godot 3.3.2 came out.
I tried this on a different PC today, and the update (to v1.0.1) gives different behaviour. It looks like the gdUnit3 files exist. I can write and run tests, but they don't run; I get this error in the output panel: res://addons/gdUnit3/src/ui/parts/InspectorTreeMainPanel.gd:308 - Invalid call. Nonexistent function 'has_meta' in base 'Nil'.
I'll retry on my original machine when I get a chance, and get back to you.
Yes i got also this error res://addons/gdUnit3/src/ui/parts/InspectorTreeMainPanel.gd:308 - Invalid call. Nonexistent function 'has_meta' in base 'Nil'.
.
Thats is because no tests are found, i will create a separate issue for this,
Up version 1.0.0 the "self" test are excluded and not anymore available.
Godot console window:
Godot Engine v3.3.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
Editing project: c:/temp/gdunit (c:::temp::gdunit)
Godot Engine v3.3.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
* daemon not running; starting now at tcp:5037
* daemon started successfully
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Close all current opened scrpts ..
Unload GdUnit3 Plugin success
Update .. extracting zip ..
tar: Cannot connect to C: resolve failed
Update .. uninstall GdUnit3 ..
Update .. install new GdUnit3 version ..
Update .. refresh editor resources ..
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: load_image: Error opening file 'res://addons/gdUnit3/addons/icon.png'.
At: core/io/image_loader.cpp:56
ERROR: _reimport_file: Error importing 'res://addons/gdUnit3/addons/icon.png'.
At: editor/editor_file_system.cpp:1817
ERROR: Cannot open file from path 'res://addons/gdUnit3/addons/icon.png.import'.
At: editor/editor_file_system.cpp:1823
ERROR: load_image: Error opening file 'res://addons/gdUnit3/icon.png'.
At: core/io/image_loader.cpp:56
ERROR: _reimport_file: Error importing 'res://addons/gdUnit3/icon.png'.
At: editor/editor_file_system.cpp:1817
ERROR: Cannot open file from path 'res://addons/gdUnit3/icon.png.import'.
At: editor/editor_file_system.cpp:1823
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/addons/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/addons/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/addons/icon.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/default_env.tres.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdunit/addons/gdUnit3/icon.png.
At: drivers/windows/file_access_windows.cpp:345
Update .. executing patches ..
Update .. enable GdUnit3 ..
WARNING: _get: Property not found: editor_plugins/enabled
At: core/project_settings.cpp:209
WARNING: set_addon_plugin_enabled: Addon 'res://addons/gdUnit3/plugin.cfg' failed to load. No directory found. Removing from enabled plugins.
At: editor/editor_node.cpp:3244
Update .. New GdUnit successfully installed
Godot's Output
window:
Godot Engine v3.3.stable.official (c) 2007-2021 Juan Linietsky, Ariel Manzur & Godot Contributors.
--- GDScript language server started ---
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Close all current opened scrpts ..
Unload GdUnit3 Plugin success
Update .. extracting zip ..
Update .. uninstall GdUnit3 ..
Update .. install new GdUnit3 version ..
Update .. refresh editor resources ..
core/io/image_loader.cpp:56 - Error opening file 'res://addons/gdUnit3/addons/icon.png'.
editor/editor_file_system.cpp:1817 - Error importing 'res://addons/gdUnit3/addons/icon.png'.
Cannot open file from path 'res://addons/gdUnit3/addons/icon.png.import'.
core/io/image_loader.cpp:56 - Error opening file 'res://addons/gdUnit3/icon.png'.
editor/editor_file_system.cpp:1817 - Error importing 'res://addons/gdUnit3/icon.png'.
Cannot open file from path 'res://addons/gdUnit3/icon.png.import'.
Update .. executing patches ..
Update .. enable GdUnit3 ..
core/project_settings.cpp:209 - Property not found: editor_plugins/enabled
editor/editor_node.cpp:3244 - Addon 'res://addons/gdUnit3/plugin.cfg' failed to load. No directory found. Removing from enabled plugins.
Update .. New GdUnit successfully installed
New Scene Root
Hm the attached logs can't be from the master.
I miss log message.
Update .. extracting zip
...
On wich branch you tested this?
And can you update to Godot 3.3.2 to verify it works on this version?
I expect this is a Godot OS.execute
bug, i find a lot of bug reports on godot github repository.
On wich branch you tested this?
I don't know what you mean. I launched Godot, opened my game/test project, and picked upgrade when prompted to upgrade gdUnit3 to the latest version.
And can you update to Godot 3.3.2 to verify it works on this version?
I see the same problem with 3.3.2.
Ok you used the assetLib to install GdUnit3 and pressed update right? I mean using the git tool to checkout the fix branch, If you not have experience to use git than this is not a option for you.
The version 1.0.1 is now available on AssetLib and can be used to "fake" a version update by modify the plugin.cfg to a lower version.
Do finally please create a fresh project and install the GdUnit3 over the assetLib, you should have than version 1.0.1 installed.
If this fails again we need deeper investigate why it's failing on your system. Maybe i will provide a short test tool to collect system info + tar version.
Apologies for the circumstances.
If i'm understanding correctly, you're asking me to:
addons/gdunit3
directory and replace the contents with a particular branch (which one?) from GitHubplugin.cfg
and change the version to 0.9.7Is that right?
Nope :) You don't need to replace manually content form the branch, the branch is already merged and included in v1.0.1.
The other option is using git and checkout the fix branch, but this is current not necessary :)
Done. Thanks for the detailed instructions.
Output window:
Godot Engine v3.3.2.stable.official (c) 2007-2021 Juan Linietsky, Ariel Manzur & Godot Contributors.
--- GDScript language server started ---
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Closing all currently opened scripts ..
Unload GdUnit3 Plugin success
Update .. extracting zip 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip' to 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update'
Extracting by `tar -xf C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip -C "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update"` failed with error code: 128
Fallback to unzip
Extracting by `unzip C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip -d C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update` failed with error code: 1
Update .. Update failed! Extracting `C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip` failed! Please collect the error log and report this.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Console window:
Editing project: c:/temp/gdnt (c:::temp::gdnt)
Godot Engine v3.3.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
* daemon not running; starting now at tcp:5037
* daemon started successfully
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Closing all currently opened scripts ..
Unload GdUnit3 Plugin success
Update .. extracting zip 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip' to 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update'
tar: Cannot connect to C: resolve failed
Extracting by `tar -xf C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip -C "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update"` failed with error code: 128
Fallback to unzip
'unzip' is not recognized as an internal or external command,
operable program or batch file.
Extracting by `unzip C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip -d C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update` failed with error code: 1
Update .. Update failed! Extracting `C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip` failed! Please collect the error log and report this.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: load_image: Error opening file 'res://addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png'.
At: core/io/image_loader.cpp:56
ERROR: _reimport_file: Error importing 'res://addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png'.
At: editor/editor_file_system.cpp:1817
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
ERROR: Failed to get modified time for: c:/temp/gdnt/addons/gdUnit3/src/update/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png.
At: drivers/windows/file_access_windows.cpp:345
Looks like it failed to un-tar, and then to unzip.
Thanks for providing the logs.
Yes unpack by tar is failing with exit code 128
and error tar: Cannot connect to C: resolve failed
The used paths looks correct. 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update/update.zip' to 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/gdnt/tmp/update'
Now gets to understand why tar is failing ;)
Can you please provide me the following infos
Open a windows console be click on the windows start button and enter cmd
type
where tar
should be output
C:\Windows\System32\tar.exe
type
tar -h
shold be output
C:\Users\Mike Schulze>tar -h
tar(bsdtar): manipulate archive files
First option must be a mode specifier:
-c Create -r Add/Replace -t List -u Update -x
Common Options:
-b # Use # 512-byte records per I/O block
-f <filename> Location of archive (default \\.\ta
-v Verbose
-w Interactive
Create: tar -c [options] [<file> | <dir> | @<archive
<file>, <dir> add these items to archive
-z, -j, -J, --lzma Compress archive with gzip/bzi
--format {ustar|pax|cpio|shar} Select archive for
--exclude <pattern> Skip files that match pattern
-C <dir> Change to <dir> before processing remain
@<archive> Add entries from <archive> to output
List: tar -t [options] [<patterns>]
<patterns> If specified, list only entries that m
Extract: tar -x [options] [<patterns>]
<patterns> If specified, extract only entries tha
-k Keep (don't overwrite) existing files
-m Don't restore modification times
-O Write entries to stdout, don't restore to di
-p Restore permissions (including ACLs, owner,
bsdtar 3.3.2 - libarchive 3.3.2 zlib/1.2.5.f-ipp
And finally systeminfo
where collects all information about your system e.g. windows version
If you don't want to share all this info you can send me also a reduced systeminfo
output.
Important to collect is
Betriebssystemname: Microsoft Windows 10 Home
Betriebssystemversion: 10.0.19043 Nicht zutreffend Build 19043
Betriebssystemhersteller: Microsoft Corporation
Betriebssystemkonfiguration: Eigenständige Arbeitsstation
Typ des Betriebssystembuilds: Multiprocessor Free
Windows-Verzeichnis: C:\WINDOWS
System-Verzeichnis: C:\WINDOWS\system32
Startgerät: \Device\HarddiskVolume1
Hotfix(es): 12 Hotfix(e) installiert.
[01]: KB5003537
[02]: KB4561600
[03]: KB4570334
[04]: KB4577266
[05]: KB4577586
[06]: KB4580325
[07]: KB4586864
[08]: KB4593175
[09]: KB4598481
[10]: KB5000736
[11]: KB5004237
[12]: KB5003742
Sorry, I didn't see your updated comment (I use emails to tell if there's something I need to do). Next time, please leave a second comment so I know you're asking for something.
Looks like I have two versions of tar
:
C:\Users\bismillah>where tar
c:\devkitPro\msys2\usr\bin\tar.exe
C:\Windows\System32\tar.exe
C:\Users\bismillah>tar -h
tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options
Try 'tar --help' or 'tar --usage' for more information.
C:\Users\bismillah>tar --help
Usage: tar [OPTION...] [FILE]...
GNU 'tar' saves many files together into a single tape or disk archive, and can
restore individual files from the archive.
Examples:
tar -cf archive.tar foo bar # Create archive.tar from files foo and bar.
tar -tvf archive.tar # List all files in archive.tar verbosely.
tar -xf archive.tar # Extract all files from archive.tar.
Local file name selection:
-C, --directory=DIR change to directory DIR
-T, --files-from=FILE get names to extract or create from FILE
-X, --exclude-from=FILE exclude patterns listed in FILE
--add-file=FILE add given FILE to the archive (useful if its name
starts with a dash)
--exclude=PATTERN exclude files, given as a PATTERN
--exclude-backups exclude backup and lock files
--exclude-caches exclude contents of directories containing
CACHEDIR.TAG, except for the tag file itself
--exclude-caches-all exclude directories containing CACHEDIR.TAG
--exclude-caches-under exclude everything under directories containing
CACHEDIR.TAG
--exclude-ignore=FILE read exclude patterns for each directory from
FILE, if it exists
--exclude-ignore-recursive=FILE
read exclude patterns for each directory and its
subdirectories from FILE, if it exists
--exclude-tag=FILE exclude contents of directories containing FILE,
except for FILE itself
--exclude-tag-all=FILE exclude directories containing FILE
--exclude-tag-under=FILE exclude everything under directories
containing FILE
--exclude-vcs exclude version control system directories
--exclude-vcs-ignores read exclude patterns from the VCS ignore files
--no-null disable the effect of the previous --null option
--no-recursion avoid descending automatically in directories
--no-unquote do not unquote input file or member names
--no-verbatim-files-from -T treats file names starting with dash as
options (default)
--null -T reads null-terminated names; implies
--verbatim-files-from
--recursion recurse into directories (default)
--unquote unquote input file or member names (default)
--verbatim-files-from -T reads file names verbatim (no escape or option
handling)
File name matching options (affect both exclude and include patterns):
--anchored patterns match file name start
--ignore-case ignore case
--no-anchored patterns match after any '/' (default for
exclusion)
--no-ignore-case case sensitive matching (default)
--no-wildcards verbatim string matching
--no-wildcards-match-slash wildcards do not match '/'
--wildcards use wildcards (default for exclusion)
--wildcards-match-slash wildcards match '/' (default for exclusion)
Main operation mode:
-A, --catenate, --concatenate append tar files to an archive
-c, --create create a new archive
--delete delete from the archive (not on mag tapes!)
-d, --diff, --compare find differences between archive and file system
-r, --append append files to the end of an archive
-t, --list list the contents of an archive
--test-label test the archive volume label and exit
-u, --update only append files newer than copy in archive
-x, --extract, --get extract files from an archive
Operation modifiers:
-G, --incremental handle old GNU-format incremental backup
-S, --sparse handle sparse files efficiently
--check-device check device numbers when creating incremental
archives (default)
-g, --listed-incremental=FILE handle new GNU-format incremental backup
--hole-detection=TYPE technique to detect holes
--ignore-failed-read do not exit with nonzero on unreadable files
--level=NUMBER dump level for created listed-incremental archive
-n, --seek archive is seekable
--no-check-device do not check device numbers when creating
incremental archives
--no-seek archive is not seekable
--occurrence[=NUMBER] process only the NUMBERth occurrence of each file
in the archive; this option is valid only in
conjunction with one of the subcommands --delete,
--diff, --extract or --list and when a list of
files is given either on the command line or via
the -T option; NUMBER defaults to 1
--sparse-version=MAJOR[.MINOR]
set version of the sparse format to use (implies
--sparse)
Overwrite control:
-U, --unlink-first remove each file prior to extracting over it
-W, --verify attempt to verify the archive after writing it
--keep-directory-symlink preserve existing symlinks to directories when
extracting
--keep-newer-files don't replace existing files that are newer than
their archive copies
-k, --keep-old-files don't replace existing files when extracting,
treat them as errors
--no-overwrite-dir preserve metadata of existing directories
--one-top-level[=DIR] create a subdirectory to avoid having loose files
extracted
--overwrite overwrite existing files when extracting
--overwrite-dir overwrite metadata of existing directories when
extracting (default)
--recursive-unlink empty hierarchies prior to extracting directory
--remove-files remove files after adding them to the archive
--skip-old-files don't replace existing files when extracting,
silently skip over them
Select output stream:
-O, --to-stdout extract files to standard output
--ignore-command-error ignore exit codes of children
--no-ignore-command-error treat non-zero exit codes of children as
error
--to-command=COMMAND pipe extracted files to another program
Handling of file attributes:
--atime-preserve[=METHOD] preserve access times on dumped files, either
by restoring the times after reading
(METHOD='replace'; default) or by not setting the
times in the first place (METHOD='system')
--clamp-mtime only set time when the file is more recent than
what was given with --mtime
--delay-directory-restore delay setting modification times and
permissions of extracted directories until the end
of extraction
--group=NAME force NAME as group for added files
--group-map=FILE use FILE to map file owner GIDs and names
--mode=CHANGES force (symbolic) mode CHANGES for added files
--mtime=DATE-OR-FILE set mtime for added files from DATE-OR-FILE
-m, --touch don't extract file modified time
--no-delay-directory-restore
cancel the effect of --delay-directory-restore
option
--no-same-owner extract files as yourself (default for ordinary
users)
--no-same-permissions apply the user's umask when extracting permissions
from the archive (default for ordinary users)
--numeric-owner always use numbers for user/group names
--owner=NAME force NAME as owner for added files
--owner-map=FILE use FILE to map file owner UIDs and names
-p, --preserve-permissions, --same-permissions
extract information about file permissions
(default for superuser)
--same-owner try extracting files with the same ownership as
exists in the archive (default for superuser)
-s, --preserve-order, --same-order
member arguments are listed in the same order as
the files in the archive
--sort=ORDER directory sorting order: none (default), name or
inode
Handling of extended file attributes:
--acls Enable the POSIX ACLs support
--no-acls Disable the POSIX ACLs support
--no-selinux Disable the SELinux context support
--no-xattrs Disable extended attributes support
--selinux Enable the SELinux context support
--xattrs Enable extended attributes support
--xattrs-exclude=MASK specify the exclude pattern for xattr keys
--xattrs-include=MASK specify the include pattern for xattr keys
Device selection and switching:
-F, --info-script=NAME, --new-volume-script=NAME
run script at end of each tape (implies -M)
-L, --tape-length=NUMBER change tape after writing NUMBER x 1024 bytes
-M, --multi-volume create/list/extract multi-volume archive
-f, --file=ARCHIVE use archive file or device ARCHIVE
--force-local archive file is local even if it has a colon
--rmt-command=COMMAND use given rmt COMMAND instead of rmt
--rsh-command=COMMAND use remote COMMAND instead of rsh
--volno-file=FILE use/update the volume number in FILE
Device blocking:
-B, --read-full-records reblock as we read (for 4.2BSD pipes)
-b, --blocking-factor=BLOCKS BLOCKS x 512 bytes per record
-i, --ignore-zeros ignore zeroed blocks in archive (means EOF)
--record-size=NUMBER NUMBER of bytes per record, multiple of 512
Archive format selection:
-H, --format=FORMAT create archive of the given format
FORMAT is one of the following:
gnu GNU tar 1.13.x format
oldgnu GNU format as per tar <= 1.12
pax POSIX 1003.1-2001 (pax) format
posix same as pax
ustar POSIX 1003.1-1988 (ustar) format
v7 old V7 tar format
-V, --label=TEXT create archive with volume name TEXT; at
list/extract time, use TEXT as a globbing pattern
for volume name
--old-archive, --portability
same as --format=v7
--pax-option=keyword[[:]=value][,keyword[[:]=value]]...
control pax keywords
--posix same as --format=posix
Compression options:
-I, --use-compress-program=PROG
filter through PROG (must accept -d)
-J, --xz filter the archive through xz
-Z, --compress, --uncompress filter the archive through compress
-a, --auto-compress use archive suffix to determine the compression
program
-j, --bzip2 filter the archive through bzip2
--lzip filter the archive through lzip
--lzma filter the archive through lzma
--lzop filter the archive through lzop
--no-auto-compress do not use archive suffix to determine the
compression program
-z, --gzip, --gunzip, --ungzip filter the archive through gzip
--zstd filter the archive through zstd
Local file selection:
-K, --starting-file=MEMBER-NAME
begin at member MEMBER-NAME when reading the
archive
-N, --newer=DATE-OR-FILE, --after-date=DATE-OR-FILE
only store files newer than DATE-OR-FILE
-P, --absolute-names don't strip leading '/'s from file names
--backup[=CONTROL] backup before removal, choose version CONTROL
-h, --dereference follow symlinks; archive and dump the files they
point to
--hard-dereference follow hard links; archive and dump the files they
refer to
--newer-mtime=DATE compare date and time when data changed only
--one-file-system stay in local file system when creating archive
--suffix=STRING backup before removal, override usual suffix ('~'
unless overridden by environment variable
SIMPLE_BACKUP_SUFFIX)
File name transformations:
--strip-components=NUMBER strip NUMBER leading components from file
names on extraction
--transform=EXPRESSION, --xform=EXPRESSION
use sed replace EXPRESSION to transform file
names
Informative output:
-R, --block-number show block number within archive with each message
--checkpoint[=NUMBER] display progress messages every NUMBERth record
(default 10)
--checkpoint-action=ACTION execute ACTION on each checkpoint
--full-time print file time to its full resolution
--index-file=FILE send verbose output to FILE
-l, --check-links print a message if not all links are dumped
--no-quote-chars=STRING disable quoting for characters from STRING
--quote-chars=STRING additionally quote characters from STRING
--quoting-style=STYLE set name quoting style; see below for valid STYLE
values
--show-defaults show tar defaults
--show-omitted-dirs when listing or extracting, list each directory
that does not match search criteria
--show-snapshot-field-ranges
show valid ranges for snapshot-file fields
--show-transformed-names, --show-stored-names
show file or archive names after transformation
--totals[=SIGNAL] print total bytes after processing the archive;
with an argument - print total bytes when this
SIGNAL is delivered; Allowed signals are: SIGHUP,
SIGQUIT, SIGINT, SIGUSR1 and SIGUSR2; the names
without SIG prefix are also accepted
--utc print file modification times in UTC
-v, --verbose verbosely list files processed
--warning=KEYWORD warning control
-w, --interactive, --confirmation
ask for confirmation for every action
Compatibility options:
-o when creating, same as --old-archive; when
extracting, same as --no-same-owner
Other options:
-?, --help give this help list
--restrict disable use of some potentially harmful options
--usage give a short usage message
--version print program version
Mandatory or optional arguments to long options are also mandatory or optional
for any corresponding short options.
The backup suffix is '~', unless set with --suffix or SIMPLE_BACKUP_SUFFIX.
The version control may be set with --backup or VERSION_CONTROL, values are:
none, off never make backups
t, numbered make numbered backups
nil, existing numbered if numbered backups exist, simple otherwise
never, simple always make simple backups
Valid arguments for the --quoting-style option are:
literal
shell
shell-always
shell-escape
shell-escape-always
c
c-maybe
escape
locale
clocale
*This* tar defaults to:
--format=gnu -f- -b20 --quoting-style=escape --rmt-command=/usr/lib/tar/rmt.exe
--rsh-command=/usr/bin/rsh
As for systeminfo
:
Host Name: DESKTOP-SFMTN1P
OS Name: Microsoft Windows 10 Home
OS Version: 10.0.19043 N/A Build 19043
OS Manufacturer: Microsoft Corporation
OS Configuration: Standalone Workstation
OS Build Type: Multiprocessor Free
System Manufacturer: Dell Inc.
System Model: G5 5500
System Type: x64-based PC
Processor(s): 1 Processor(s) Installed.
[01]: Intel64 Family 6 Model 165 Stepping 2 GenuineIntel ~2592 Mhz
BIOS Version: Dell Inc. 1.9.0, 6/1/2021
Windows Directory: C:\WINDOWS
System Directory: C:\WINDOWS\system32
Boot Device: \Device\HarddiskVolume1
System Locale: en-us;English (United States)
Input Locale: en-us;English (United States)
Time Zone: (UTC-05:00) Eastern Time (US & Canada)
Total Physical Memory: 16,178 MB
Available Physical Memory: 9,265 MB
Virtual Memory: Max Size: 18,610 MB
Virtual Memory: Available: 7,618 MB
Virtual Memory: In Use: 10,992 MB
Page File Location(s): C:\pagefile.sys
Domain: WORKGROUP
Hotfix(s): 13 Hotfix(s) Installed.
[01]: KB5003537
[02]: KB4561600
[03]: KB4566785
[04]: KB4570334
[05]: KB4577266
[06]: KB4577586
[07]: KB4580325
[08]: KB4586864
[09]: KB4593175
[10]: KB4598481
[11]: KB5000736
[12]: KB5004237
[13]: KB5003742
Thanks for providing this infos
C:\Users\bismillah>where tar
c:\devkitPro\msys2\usr\bin\tar.exe
C:\Windows\System32\tar.exe
I had already suspected that there are several tar versions installed. Now I know how I can address the problem ;) Obviously I need to specify the full path to the tar for Windows to avoid confusion.
Thanks a lot
Hi @nightblade9 the issue should now be fixed. To finally publish i would you ask to test it before please.
Please download the https://github.com/MikeSchulze/gdUnit3/archive/refs/heads/GD-113.zip and install it manually in a fresh project.
plugin.cfg
to version 0.9.7 The update should now ends up with success.
Best Regards
Ah, now this is strange. If I run a command-prompt and type unzip
I get 'unzip' is not recognized [...] as a command
. I have a copy in AppData\local\programs\git\usr\bin, though, I guess it's just not added to the path by default.
Godot Engine v3.3.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
Editing project: c:/temp/GD113 (c:::temp::GD113)
Godot Engine v3.3.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
OpenGL ES Batching: ON
GdUnit3: Set inital settings 'gdunit3/settings/update_notification_enabled' to 'True'.
GdUnit3: Set inital settings 'gdunit3/settings/server_connection_timeout_minutes' to '30'.
GdUnit3: Set inital settings 'gdunit3/settings/test_timeout_seconds' to '300'.
GdUnit3: Set inital settings 'gdunit3/report/error_notification' to 'False'.
GdUnit3: Set inital settings 'gdunit3/report/verbose_orphans' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_errors' to 'True'.
GdUnit3: Set inital settings 'gdunit3/report/assert/verbose_warnings' to 'True'.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
* daemon not running; starting now at tcp:5037
* daemon started successfully
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
Update .. Downloading update ..
Update .. disable GdUnit3 ..
Closing all currently opened scripts ..
Unload GdUnit3 Plugin success
Update .. extracting zip 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update/update.zip' to 'C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update'
Detect OS : Windows
The filename, directory name, or volume label syntax is incorrect.
Extracting by `c:\devkitPro\msys2\usr\bin\tar.exeC:\Windows\System32\tar.exe -xf "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update/update.zip" -C "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update"` failed with error code: 1
Fallback to unzip
'unzip' is not recognized as an internal or external command,
operable program or batch file.
Extracting by `unzip C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update/update.zip -d C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update` failed with error code: 1
Update .. Update failed! Extracting `C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update/update.zip` failed! Please collect the error log and report this.
GdUnit3: Server successfully started on port 31002
Loading GdUnit3 Plugin success
download immage: https://user-images.githubusercontent.com/7442115/126648680-6347535d-bf51-4dd1-9504-12014ba449f5.png
On Windows the tar tool is provided by default, C:\Windows\System32\tar.exe
I scan the path for tar but looks like it works not as expected
The filename, directory name, or volume label syntax is incorrect. Extracting by
c:\devkitPro\msys2\usr\bin\tar.exeC:\Windows\System32\tar.exe -xf "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update/update.zip" -C "C:/Users/bismillah/AppData/Roaming/Godot/app_userdata/GD113/tmp/update"failed with error code: 1 Fallback to unzip
This looks strange c:\devkitPro\msys2\usr\bin\tar.exeC:\Windows\System32\tar.exe
Ok i found the problem the OS.execute
works different as expected.
It collects the stdout in an array but it contains only one element.
All lines are combined be "\n" and needs to be manually splitted, what a shidt. ;)
I updated the branch, it should now work. You have to download https://github.com/MikeSchulze/gdUnit3/archive/refs/heads/GD-113.zip again for testing ;)
Looks like that resolved it. Thanks for following up on this issue until it's resolved.
To confirm, I:
Thanks so much for helping finding this bug. The fix will be included in v1.0.3
The used Godot version: 3.3
OS including version: Windows 10
Describe the bug After upgrading to v1.0.0, the
addons/gdunit3
directory gets wiped out.Steps to Reproduce
Expected: the plugin upgrades itself Actual: the plugin wipes out the
addons/gdunit3
directoryYou could also update the assetlib version to v1.0.0 to temporarily work around this problem.