MikeSchulze / gdUnit4

A Godot Unit Test Framework. Support for GDScript and C# unit testing

MIT License

565 stars 30 forks source link

GD-503: Rework plugin exit to avoid system crash and memory leaks #504

Closed MikeSchulze closed 3 months ago

MikeSchulze commented 3 months ago

Why

The plugin has some issues to release resources at Godot exit and result sometimes in a segmentation fault under Linux

What

fix remove_child on free_instance to be called deferred now
removed the temporary free_fix workaround
fix orphan nodes in GdUnitTestDiscoverer
introduce a new flag to call deferred on free_instance at plugin exit

Godot bug related

https://github.com/godotengine/godot/issues/92727

MikeSchulze commented 3 months ago

@AnidemDex please check out this branch, and check if you run in errors or crashes. I tested on Windows and macOS, the tests runs and when exit Godot no real errors I see, also no orphans on Windows, but leaked images on macOS only

AnidemDex commented 3 months ago

Segfault is no more