search

MikeSchulze / gdUnit4

A Godot Unit Test Framework. Support for GDScript and C# unit testing
MIT License
565 stars 30 forks source link

GD-577: C# Parameterized tests not counted in total count #577

Open poohcom1 opened 1 week ago

poohcom1 commented 1 week ago

The used GdUnit4 version

4.3.4 (Latest Release)

The used Godot version

v4.3.stable

Operating System

Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; 32.0.15.5599) - AMD Ryzen 7 5800H with Radeon Graphics (16 Threads)

Describe the bug

Note: I'm using C#, haven't tested to see if this bug also happens in GDScript

Parameterized tests are not included into "total_count", causing the progress bar value to be a bit misleading.

image

Sidenote, I think the progress bar delimiter should be changed from ":" to "/", it represents progress much more clearly. Just my opinion, though.

image

Steps to Reproduce

  1. Create parameterized tests in C#.
  2. Run tests.
  3. See progress bar.

Minimal reproduction project

No response

MikeSchulze commented 1 week ago

Hi, can you verify this issue with the latest release v4.4.0 (master branch), I did some refactorings in this area and this issue should be resolved with v4.4.0

poohcom1 commented 1 week ago

Tested with master branch, using gdUnit4.api v4.3.1, and ran into a different issue where only GDScript tests were being counted, probably because I was using older C# version since I couldn't find the newer version on nuget. If you release an rc version I can check again with that.

image

But I did confirm parameterized tests in GDScript doesn't have this issue, in both 4.4.0 and 4.3.1.

image

MikeSchulze commented 1 week ago

Ok seams we have an issue here, thanks for reporting. With GdUnit4.4 I introduced the flaky test handling and changed the way how to communicate counters to the status bar.

I need to re-investigate the changes to find a solution it works for GDScript and existing C# API.

MikeSchulze commented 1 week ago

@poohcom1 if you develop your C# using external IDE, I suggest installing the gdunit4-test-adaper. This allows you to direct develop and debug tests in your IDE.

check out https://github.com/MikeSchulze/gdUnit4Net/blob/master/testadapter/README.md