MikeSiLVO / skin.aeon.nox.silvo

A skin for Kodi
Other
123 stars 94 forks source link

Kodi 18/19 Dvd & Bluray Menus not working on Aeon-Nox-SiLVO Skin #121

Closed snake3ca closed 4 years ago

snake3ca commented 4 years ago

When launching a DVD Iso or Bluray Iso using the Aeon Nox SiLVO skin on Kodi 18 or Kodi 19 the menus do not work properly. This bug happens when launching them from the library only. If you launch the Iso from the file manager section or from the information context menu the Iso shows the menu correctly. This bug does not happen on the stock Kodi skin. When Launching from the library it does not detect it as a disc image when using Aeon Nox skin.

In debug log on the default skin it shows matches rule: dvdimage. DVD menu works correct when this happens.

2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers(nfs://192.168.0.100/mnt/Concerts/Concerts/Alison Krauss and Union Station Live (Disc 1) (2003)/Alison Krauss and Union Station Live (Disc 1).iso) 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: system rules 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: system rules 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: mms/udp 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: lastfm/shout 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtmp 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtsp 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvd 2020-07-18 12:19:45.273 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvdimage 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: dvdimage 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: adding player: VideoPlayer for rule: dvdimage 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: sdp/asf 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: nsv 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: radio 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers: matched 1 rules with players 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers: adding videodefaultplayer (VideoPlayer) 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=0 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=1 2020-07-18 12:19:45.274 T:140416781847232 DEBUG: CPlayerCoreFactory::GetPlayers: added 2 players 2020-07-18 12:19:45.279 T:140416781847232 DEBUG: Radio UECP (RDS) Processor - new CDVDRadioRDSData

In the debug log with the aeon nox silvo skin it shows CPlayerCoreFactory::GetPlayers: matched 0 rules with players. DVD menu doesnt work correctly when this happens.

2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers(nfs://192.168.0.100/mnt/Concerts/Concerts/Alison Krauss and Union Station Live (Disc 1) (2003)/Alison Krauss and Union Station Live (Disc 1).iso) 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: system rules 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: system rules 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: mms/udp 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: lastfm/shout 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtmp 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtsp 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvd 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvdimage 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: sdp/asf 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: nsv 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: radio 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers: matched 0 rules with players 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers: adding videodefaultplayer (VideoPlayer) 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=0 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=1 2020-07-18 12:17:23.186 T:139637478812352 DEBUG: CPlayerCoreFactory::GetPlayers: added 1 players 2020-07-18 12:17:23.188 T:139637478812352 DEBUG: Radio UECP (RDS) Processor - new CDVDRadioRDSData

In the debug log with aeon nox silvo when lauching from the information menu it detects the dvd image correctly. DVD menus work correctly when this happens.

2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerCoreFactory::GetPlayers(nfs://192.168.0.100/mnt/Concerts/Concerts/Alison Krauss and Union Station Live (Disc 1) (2003)/Alison Krauss and Union Station Live (Disc 1).iso) 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: system rules 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: system rules 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: mms/udp 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: lastfm/shout 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtmp 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtsp 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvd 2020-07-18 12:18:13.833 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvdimage 2020-07-18 12:18:13.834 T:140095696358080 DEBUG: CAddonDatabase: SELECT repo.id FROM repo .. took 0 ms 2020-07-18 12:18:13.843 T:140095696358080 DEBUG: CAddonDatabase: query SELECT * FROM addons JOIN addonlinkrepo ON addons.id=addonlinkrepo.idAddon WHERE addonlinkrepo.idRepo IN (1) ORDER BY addons.addonID returned 1102 rows in 9 ms 2020-07-18 12:18:13.917 T:140095696358080 DEBUG: CAddonDatabase::GetAddons took 83 ms 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: dvdimage 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: adding player: VideoPlayer for rule: dvdimage 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: sdp/asf 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: nsv 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: radio 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerCoreFactory::GetPlayers: matched 1 rules with players 2020-07-18 12:18:13.922 T:140095696358080 DEBUG: CPlayerCoreFactory::GetPlayers: adding videodefaultplayer (VideoPlayer)

snake3ca commented 4 years ago

Kodi log when using Aeon Nox Silvo: https://pastebin.com/qZjS2ZAj

Kodi log when using Stock Skin: https://pastebin.com/SkKCM3b8

Kodi log when loading iso using Aeon Nox Silvo from information context menu: https://pastebin.com/VEvYwT6m

MikeSiLVO commented 4 years ago

Try Change action and selecting Custom item, it's at the bottom, and change it to: ActivateWindow(Videos,library://video/musicvideos/titles.xml/,return) image

snake3ca commented 4 years ago

yes that fixes the issue, thank you for looking into this.

snake3ca commented 4 years ago

can this be updated in skin.aeon.nox.silvo/shortcuts/mainmenu.DATA.xml ?

snake3ca commented 4 years ago

Looks like this doesnt completly resolve the issue. If you play an ISO then try to play it again it doesnt start. Log shows error probing input format.

Here is the part of the log when trying to load the ISO.

2020-07-26 09:53:40.238 T:140066231924480 DEBUG: CNFSFile::Open - opened mnt/Concerts/Concerts/Aerosmith Rocks Donington 2014 (2015)/Aerosmith Rocks Donington 2014.iso 2020-07-26 09:53:40.239 T:140066231924480 DEBUG: ScanForExternalSubtitles: Searching for subtitles... 2020-07-26 09:53:40.239 T:140066659755776 DEBUG: Loading settings for videodb://musicvideos/titles/5902?xsp=%7b%22order%22%3a%7b%22direction%22%3a%22ascending%22%2c%22ignorefolders%22%3a0%2c%22method%22%3a%22title%22%7d%2c%22type%22%3a%22musicvideos%22%7d 2020-07-26 09:53:40.239 T:140066231924480 DEBUG: ScanForExternalSubtitles: END (total time: 1 ms) 2020-07-26 09:53:40.239 T:140066231924480 NOTICE: Creating Demuxer 2020-07-26 09:53:40.239 T:140067546241728 DEBUG: CVideoGUIInfo::InitCurrentItem(videodb://musicvideos/titles/5902?xsp=%7b%22order%22%3a%7b%22direction%22%3a%22ascending%22%2c%22ignorefolders%22%3a0%2c%22method%22%3a%22title%22%7d%2c%22type%22%3a%22musicvideos%22%7d) 2020-07-26 09:53:40.239 T:140067546241728 DEBUG: CPlayerGUIInfo::InitCurrentItem(videodb://musicvideos/titles/5902?xsp=%7b%22order%22%3a%7b%22direction%22%3a%22ascending%22%2c%22ignorefolders%22%3a0%2c%22method%22%3a%22title%22%7d%2c%22type%22%3a%22musicvideos%22%7d) 2020-07-26 09:53:40.320 T:140066231924480 ERROR: Open - error probing input format, nfs://192.168.0.100/mnt/Concerts/Concerts/Aerosmith Rocks Donington 2014 (2015)/Aerosmith Rocks Donington 2014.iso 2020-07-26 09:53:40.320 T:140066231924480 ERROR: OpenDemuxStream - Error creating demuxer 2020-07-26 09:53:40.320 T:140066231924480 NOTICE: CVideoPlayer::OnExit() 2020-07-26 09:53:40.320 T:140066231924480 DEBUG: CNFSFile::Close closing file mnt/Concerts/Concerts/Aerosmith Rocks Donington 2014 (2015)/Aerosmith Rocks Donington 2014.iso 2020-07-26 09:53:40.320 T:140066231924480 DEBUG: Thread VideoPlayer 140066231924480 terminating 2020-07-26 09:53:40.324 T:140067222066944 DEBUG: Mysql execute: update settings set Deinterlace=1,ViewMode=0,ZoomAmount=1.000000,PixelRatio=1.000000,VerticalShift=0.000000,AudioStream=-1,SubtitleStream=-1,SubtitleDelay=0.000000,SubtitlesOn=1,Brightness=50.000000,Contrast=50.000000,Gamma=20.000000,VolumeAmplification=0.000000,AudioDelay=0.000000,Sharpness=0.000000,NoiseReduction=0.000000,NonLinStretch=0,PostProcess=0,ScalingMethod=1,ResumeTime=0,StereoMode=0,StereoInvert=0,VideoStream=-1,TonemapMethod=1,TonemapParam=1.000000 where idFile=9 2020-07-26 09:53:40.325 T:140066659755776 DEBUG: OnPlayBackStopped: CApplication::OnPlayBackStopped 2020-07-26 09:53:40.340 T:140067546241728 DEBUG: ------ Window Init (DialogBusy.xml) ------ 2020-07-26 09:53:40.341 T:140067546241728 NOTICE: CVideoPlayer::CloseFile() 2020-07-26 09:53:40.341 T:140067546241728 DEBUG: DeleteRenderer - deleting renderer 2020-07-26 09:53:40.341 T:140067546241728 DEBUG: LinuxRendererGL: Cleaning up GL resources 2020-07-26 09:53:40.341 T:140067546241728 NOTICE: VideoPlayer: waiting for threads to exit 2020-07-26 09:53:40.341 T:140067546241728 NOTICE: VideoPlayer: finished waiting 2020-07-26 09:53:40.341 T:140067546241728 DEBUG: Radio UECP (RDS) Processor - delete ~CDVDRadioRDSData 2020-07-26 09:53:40.346 T:140067546241728 DEBUG: ------ Window Deinit (DialogBusy.xml) ------ 2020-07-26 09:53:40.410 T:140066366142208 DEBUG: [plugin.video.youtube] PlaybackMonitor active threads: ||

snake3ca commented 4 years ago

On the stock skin if you play an ISO twice it also doesnt show the DVD menu the 2nd time, so this may not be an with this skin.

snake3ca commented 4 years ago

This bug is present in the stock kodi skin so its not a bug with your skin, I will close this issue. Thanks for looking into it, great skin!