MikeSiLVO / skin.aeon.nox.silvo

A skin for Kodi
Other
123 stars 94 forks source link

myflix view - logo vertical alignment change #160

Closed monisriz closed 2 years ago

monisriz commented 2 years ago

Reason for the change:

The current bottom align for "aligny" works well for logos on fanart.tv since they have a strict rule about logos being 800px by 310px.

However, TMDB also introduced logos recently. TMDB doesn't have a size restriction. TMDB also does not care about any aspect ratio. It trims any transparent part around the logo and reduces the dimensions of the uploaded logo to a minimum. Some logos are just simply text in one line and TMDB reduces them to a thin strip of text with no padding around the text at all. When aligny=bottom is used these logos sometimes sit just barely on top of the info section and this leaves a huge space above the logo empty.

Using aligny="center" nicely puts the logo in the center (vertically) leaving some space at the bottom and the top if needed.

For example, logos from TMDB and Fanart.tv for "Dynasties": https://www.themoviedb.org/tv/82953-dynasties/images/logos https://fanart.tv/series/352054/dynasties-2019/

See screenshots below for clarity - used logos from TMDB (since it's the default TV show scrapper for Kodi now):

Before Change: image

After Change:

image

MikeSiLVO commented 2 years ago

Thanks :)