MikeSiLVO / skin.aeon.nox.silvo

A skin for Kodi
Other
123 stars 94 forks source link

Feature request: Fixed list #91

Closed GMib closed 5 years ago

GMib commented 5 years ago

please add "fixed list" option in right list view.

sorry for my bad english

MikeSiLVO commented 5 years ago

Can you be more specific?

Also why do you think I should add it?

GMib commented 5 years ago

i replace list by fixedlist in View_506_RightList.xml : `

4` line 189 I hate having focus in last/first line, i can't see next/previous movie and I find it less beautiful. i edit file myself, but i do edit again each update ;( Sorry for not being more explicit, it's hard for me to argue in English
MikeSiLVO commented 5 years ago

If you mean this: Imgur

Then sorry but no won't be added but if I add <movement>5<movement> and start scrolling on the center item then maybe I can add an option: Imgur

GMib commented 5 years ago

yes, it's what i mean, but i didn't know <movement>, i've just tested it and it's better ;)

TacticalTurtleneck commented 5 years ago

Hi AKA HYPERIONzoom here, Like GMib I much prefer the centred and locked focus when scrolling through titles. So much so that I exclusively use views that support it to the exclusion of some very good alternative views.

"...if I add movement>5<movement and start scrolling on the center item then maybe I can add an option"

I don't quite understand what you are proposing here. Would this result in a centred and locked focus? If so, could the option be included in other linear views? *linear = list-like, both vertical and horizontal

GMib commented 5 years ago

yes focus remains centered except at the beginning or end of the list. description of movement tag in https://kodi.wiki/view/Fixed_List_Container : This will make the focused position scroll again at the end of the list. (ie. 6 if there are only 6 items below the focus, the focus moves down to the bottom)

TacticalTurtleneck commented 5 years ago

It's an option that has been present in other Aeon Nox skins but sadly have been unsupported in recent Kodi versions.

MikeSiLVO commented 5 years ago

@TacticalTurtleneck It is a lot easier to understand if you test the code but I'll see if I can explain it well enough with some pics.

The list starts focused at the top: Imgur

Then when it hits the center item the list itself scrolls: Imgur

Until you reach the end where it will move down the list again: Imgur

MikeSiLVO commented 5 years ago

@TacticalTurtleneck What other Nox skins are you talking about?

TacticalTurtleneck commented 5 years ago

yes focus remains centered except at the beginning or end of the list. description of movement tag in https://kodi.wiki/view/Fixed_List_Container : This will make the focused position scroll again at the end of the list. (ie. 6 if there are only 6 items below the focus, the focus moves down to the bottom)

@GMib and @mikesilvo164: Yes, that's exactly what I'm after! However, I don't know how to implement that at this stage. Ideally I'd prefer the option to be included in the skin UI.

TacticalTurtleneck commented 5 years ago

@TacticalTurtleneck What other Nox skins are you talking about?

From memory it was in the original Aeon Nox 4 and Aeon Nox XBMCMania. EDIT: That said it was not an option on all views, just a select few.

MikeSiLVO commented 5 years ago

@GMib & @TacticalTurtleneck I will push some finished code for you guys to test in a few minutes for just RightList view for now.

Enable in view settings: Imgur

MikeSiLVO commented 5 years ago

You guys using leia or master branch?

GMib commented 5 years ago

18.3 nightly for me

TacticalTurtleneck commented 5 years ago

18.3 for me also. EDIT: not the nightly but the vanilla, stable release.

MikeSiLVO commented 5 years ago

Ok I'll push to both leia and master then

MikeSiLVO commented 5 years ago

@GMib @TacticalTurtleneck Changes pushed and should be available now.

TacticalTurtleneck commented 5 years ago

Thank you!

TacticalTurtleneck commented 5 years ago

Gosh, that makes the world of a difference!! To be honest I was a little bummed that we were starting with RightList because it's been low on my favourites list- but now! It's been transformed with this one small tweak! I think this will be my new goto view for TV shows and keep Showcase for Movies.

Now if we could have the option to replace the titles with banners... Just kidding! Baby steps. ;)

GMib commented 5 years ago

thanks, there is a problem for me, black screen if i update, must crash kodi, i've set estuary by default then relaunch update, since aeon nox is not displayed, i've got error if i reinstall ;( trying to delete folder

MikeSiLVO commented 5 years ago

@GMib Exactly how are you doing the Git Pull? Are you using CLI or GUI like SmartGit?

GMib commented 5 years ago

i've only use kodi update in extention menu. all work again after delete skin folder.

MikeSiLVO commented 5 years ago

@TacticalTurtleneck Banners won't fit. Would have to re-design the whole view.

Would be better to use InfoWall and switch to banners or create a whole new view which I am not to keen on doing ATM...

GMib commented 5 years ago

strange kodi suggests me 7.0.3 update then i've already.

TacticalTurtleneck commented 5 years ago

@TacticalTurtleneck Banners won't fit. Would have to re-design the whole view.

Would be better to use InfoWall and switch to banners or create a whole new view which I am not to keen on doing ATM...

No problem, no problem. I remember other Nox skins used banners in Tri-Panel which looked a treat- But I don't want to derail too much.

On topic of fixed list AKA centred and locked focus; if you were to add it to another view could you add it to "List". I mention it because it's often the only view available for some addons like Extras and YouTube.

MikeSiLVO commented 5 years ago

@GMib You can't update in Kodi. You are on GitHub not the Kodi forums.

I have updated the skin for testing on GitHub only.

You can check the instructions in the first post of my skin thread HERE

MikeSiLVO commented 5 years ago

@TacticalTurtleneck Banners won't fit. Would have to re-design the whole view. Would be better to use InfoWall and switch to banners or create a whole new view which I am not to keen on doing ATM...

No problem, no problem. I remember other Nox skins used banners in Tri-Panel which looked a treat- But I don't want to derail too much.

On topic of fixed list AKA centred and locked focus; if you were to add it to another view could you add it to "List". I mention it because it's often the only view available for some addons like Extras and YouTube.

That's a little iffy here cause when the items are less than a full page the list would be centered in the list background and I don't think thats gonna look good at all. I would have to add a bunch of conditional slide animations to raise it but...

I'll begrudgingly look into adding it sometime in the near future possibly today, tomorrow or the following.

GMib commented 5 years ago

ok, next kodi update will contain fixed option ? I edit file myself and wait future update. thanks a lot ;)

TacticalTurtleneck commented 5 years ago

I'll begrudgingly look into adding it sometime in the near future possibly today, tomorrow or the following.

Take your time! I've been waiting for years for more views with fixed focus/banners and you know what? These a minor first-world quibbles. I can honestly get by with the way it is. It's just on my wishlist, that's all.

If you feel like adding it, I'd be over the moon. If not, c'est la vie.

TacticalTurtleneck commented 5 years ago

ok, next kodi update will contain fixed option ? I edit file myself and wait future update. thanks a lot ;)

You can download the latest version here on GitHub as a zip. Then in Kodi install the addon from zip file and you'll have the latest Git update. That's how I do it anyway.

MikeSiLVO commented 5 years ago

You can download the latest version here on GitHub as a zip. Then in Kodi install the addon from zip file and you'll have the latest Git update. That's how I do it anyway.

You really should delete the skin folder first and open the zip file up in winRar or something then remove -master from the end before installing from zip. Doing it like you mention could create multiple skin folders and that has caused some major issues in the past.

Edit: Actually you should rename the folder to skin.aeon.nox.silvo

GMib commented 5 years ago

In FAQ : The latest version can be downloaded from GitHub but DO NOT INSTALL through the addon manager. i prefer wait for repository, i'm not pressed i know how to edit file.

TacticalTurtleneck commented 5 years ago

Ah, good to know. Thanks to you both.

I just reread the FAQ and I just want to confirm which addons folder you are referring to because there are several. Is it the one in Appdata > Roaming > Kodi > addons ?

MikeSiLVO commented 5 years ago

On Windows that is correct unless you run in portable mode then it would be the Kodi install folder > portable_data > addons

MikeSiLVO commented 5 years ago

Also I added that DO NOT INSTALL from add-on manager message to eliminate installation issues from some people thinking that just switching out a file makes things work when it is likely more than one file that needs replacing so unless you really know what you're doing, best practice is to delete the whole folder and re-install to eliminate possible mismatches causing problems.

TacticalTurtleneck commented 5 years ago

That's good advice.

MikeSiLVO commented 5 years ago

Alternatively you could use SmartGit, which I use myself, to pull updates directly from GitHub.

I can tell you how to set it up if you are interested.

TacticalTurtleneck commented 5 years ago

Yes, tell me about this... SmartGit. I've heard mention of it. But there's probably instructions already made somewhere?

MikeSiLVO commented 5 years ago

Ok. First download from HERE

MikeSiLVO commented 5 years ago

When you install make sure and choose free for non-commercial use or something like that.

TacticalTurtleneck commented 5 years ago

Yes, I balked at the price. There's a free version I take it?

MikeSiLVO commented 5 years ago

Free install then when you open the program it asks if you want to be paid or non-commercial and you choose non-commercial.

If you have any questions during install and launch just let me know what you see and I'll tell you what to do :smiley:

From the website: Non-Commercial Licenses SmartGit can be used free of charge by Open Source developers, teachers and their students, or for hobby, non-paid usage. We are also supporting certain non-profit organizations like public welfare or charities. If in doubt, please contact sales.

TacticalTurtleneck commented 5 years ago

OK, so I've added your SVN to SmartGit and I'm up to the part where I need to point SmartGit at my local folder. Should I point to my "AppData\Roaming\Kodi\addons" or "AppData\Roaming\Kodi\addons\skin.aeon.nox.silvo"?

MikeSiLVO commented 5 years ago

Pretty sure just addons cause then it should clone the repo in an Aeon-Nox-SiLVO folder

I would leave it that way and not have the folder the same as from the Kodi repo cause it adds a hidden .git folder for versioning and branch info. Just make sure there are no other Nox SiLVO folder in there i.e. skin.aeon.nox.silvo or any other folder with silvo in in it.

MikeSiLVO commented 5 years ago

You are using clone in the repository menu and not add right?

TacticalTurtleneck commented 5 years ago

I think so. Like this? 01

MikeSiLVO commented 5 years ago

Yep looks good now you have to check out the leia branch cause that is what you are using.

If the branches window is open just double click on leia in the bottom left section.

If it is not open then CTRL+SHIFT+2 will open it.

TacticalTurtleneck commented 5 years ago

I chose this option when setting up the clone. Is that right? 2019-08-08 03_33_29-Clone

MikeSiLVO commented 5 years ago

Yeah but if it still says (master) after .git then you are not checked out on leia branch.

TacticalTurtleneck commented 5 years ago

In SmartGit: 03

And in my addons folder is deposits a folder named: Aeon-Nox-SiLVO.git