MikeTaylor / scottkit

Scott Adams adventure toolkit: compile, decompile and play 80s-style adventure games
30 stars 10 forks source link

Use /usr/bin/env rather than hardcoded ruby path #10

Closed drewish closed 6 years ago

drewish commented 6 years ago

I'm using ruby built with ruby-build and rbenv so it's not in /usr/local/bin my understanding is this is the right way to specify it now.

andrew:~/projects/scottkit (master)% ./bin/scottkit 
./bin/scottkit: Command not found.
andrew:~/projects/scottkit (master)% which ruby
/Users/andrew/.rbenv/shims/ruby
andrew:~/projects/scottkit (master)% ruby ./bin/scottkit 
./bin/scottkit: No data-file specified
Usage: ./bin/scottkit [options] [<data-file>]
(ScottKit version 1.5.0)
[...]
andrew:~/projects/scottkit (master)% git checkout shebang
Switched to branch 'shebang'
Your branch is up-to-date with 'origin/shebang'.
andrew:~/projects/scottkit (shebang)% ./bin/scottkit
./bin/scottkit: No data-file specified
Usage: ./bin/scottkit [options] [<data-file>]
(ScottKit version 1.5.0)
[...]
drewish commented 6 years ago

My understanding from: https://www.ruby-forum.com/topic/96121 is that it's not compatible. If you want the warnings it sounds like we can add $VERBOSE=true up top.

MikeTaylor commented 6 years ago

OK, let's do that. Push another commit to the PR and I will merge it.

It'll be great to have the first non-me commits!

drewish commented 6 years ago

Cool updated the commit to take that into account.

MikeTaylor commented 6 years ago

Check it out: this project has two contributors! https://github.com/MikeTaylor/scottkit/graphs/contributors