Mikesch-mp / icingaweb2-module-grafana

Grafana module for Icinga Web 2 (supports InfluxDB & Graphite)
https://icinga.com/community/
GNU General Public License v2.0
241 stars 95 forks source link

iframe mode: Add size and direct link option #268

Open bargru opened 3 years ago

bargru commented 3 years ago

First of all, thank you for the 1.4 release! The iframe mode is now running much smoother.

However, it would be nice if the following options were available for the iframe in the settings (as with the proxy):

Expected Behavior

Current Behavior

Options are only available for proxy mode.

Possible Solution

None

Your Environment

n3k232 commented 3 years ago

+1

Steppensturm commented 3 years ago

+1

cadirol commented 3 years ago

Hi First of all, thank you for the update! After Upgrading i was a bit confused about the width of the Graphs in iframe Mode. As i can read in the comment from @bargru, the size of the iframe should be done via manual setting. Did something changed with the iframe setting? The Graphs now looks smaller than before the upgrade. ... i know, maybe i am outdated with my question... Thank you for your work!

roman-rs commented 2 years ago

same here. the iframe width is much smaller than it's set in the graph settings.

If I enable repeated Yes in the graph settings, then all the repeated 10 iFrames are of correct width. but that cannot be a workaround, of course. in this case one graph is correct and useful and 9 frames with empty graphs as it cannot find all the non-existing panelIds. Turn of the repeated setting, and width is too small again.

for now, I worked around it by hardcoding width that I like in library/Grafana/ProvidedHook/Grapher.php:249

cadirol commented 2 years ago

@roman-rs Thank you very much for your workaround! The change in Grapher.php works, but yes, can't be the final solution

kordickf commented 1 year ago

Hi there, here is the solution to your problem - so you can change the width of your grafana graph embedded in icinga: https://github.com/Mikesch-mp/icingaweb2-module-grafana/issues/307

It also isn't hardcoded, width can be changed as needed.