search

Mikesch-mp / icingaweb2-module-grafana

Grafana module for Icinga Web 2 (supports InfluxDB & Graphite)
https://icinga.com/community/
GNU General Public License v2.0
241 stars 95 forks source link

Grafana Image link at icingadb-web borken if LC not en_XX #292

Closed mafri27 closed 2 years ago

mafri27 commented 2 years ago

I'm not sure if this is a issue at your plugin or at the icingadb-web. Please close it if I'm at the wrong project.

If the Icinga language is set to de_DE for example the generated Image tag link include some broken characters.

en_EN: https://server/icingaweb2/grafana/img?host=foo&service=bar&panelid=1&timerange=now-24h&timerangeto=now&cachetime=573.26800012589

de_DE https://server/icingaweb2/grafana/img?host=foo&service=bar&panelid=1&timerange=now-24h&timerangeto=now&cachetime=573%2C26800012589

This cause an error while loading the Image. I think the reason is the gergan is using "," as decimal separator (like other languages )

A non well formed numeric value encountered

#0 /usr/share/icingaweb2/modules/grafana/application/controllers/ImgController.php(201): Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}()
#1 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(507): Icinga\Module\Grafana\Controllers\ImgController->indexAction()
#2 /usr/share/php/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch()
#3 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch()
#4 /usr/share/php/Icinga/Application/Web.php(290): Zend_Controller_Front->dispatch()
#5 /usr/share/php/Icinga/Application/webrouter.php(105): Icinga\Application\Web->dispatch()
#6 /usr/share/icingaweb2/public/index.php(4): require_once(String)
#7 {main}
$ icingacli --version
Icinga Web 2  2.11.0    
Git Commit    46998464ea9f9e3c2889d98f9fb6df639d972550 
PHP Version   7.4.28    
MODULE       VERSION   
grafana      1.4.2     
icingadb     1.0.0     
lazaroblanc  1.0.0     
monitoring   2.11.0
$ lsb_release -d
Description:    Debian GNU/Linux 11 (bullseye)
$ icinga2 --version
icinga2 - The Icinga 2 network monitoring daemon (version: r2.13.4-1)

System information:
  Platform: Debian GNU/Linux
  Platform version: 11 (bullseye)
  Kernel: Linux
  Kernel version: 5.10.0-8-amd64
  Architecture: x86_64

Build information:
  Compiler: GNU 10.2.1
  Build host: runner-hh8q3bz2-project-298-concurrent-0
  OpenSSL version: OpenSSL 1.1.1n  15 Mar 2022
$ icinga2 feature list
Disabled features: 
Enabled features: api checker ido-pgsql influxdb mainlog syslo
$ icinga2 daemon -C
[2022-07-01 15:13:29 +0000] information/cli: Icinga application loader (version: r2.13.4-1)
[2022-07-01 15:13:29 +0000] information/cli: Loading configuration file(s).
[2022-07-01 15:13:29 +0000] information/ConfigItem: Committing config item(s).
[2022-07-01 15:13:29 +0000] warning/Zone: The Zone object 'checker' has more than two endpoints. Due to a known issue this type of configuration is strongly discouraged and may cause Icinga to use excessive amounts of CPU time.
[2022-07-01 15:13:29 +0000] information/ApiListener: My API identity: icinga-master-1.hetzner.com
[2022-07-01 15:13:39 +0000] information/WorkQueue: Icinga/icingadb-web#9 (ApiListener, RelayQueue) items: 0, rate:  0/s (0/min 0/5min 0/15min);
[2022-07-01 15:13:39 +0000] information/WorkQueue: Icinga/icingadb-web#10 (ApiListener, SyncQueue) items: 0, rate:  0/s (0/min 0/5min 0/15min);
[2022-07-01 15:13:39 +0000] information/WorkQueue: Icinga/icingadb-web#5 (DaemonUtility::LoadConfigFiles) items: 32, rate: 174.933/s (10496/min 10496/5min 10496/15min);
[2022-07-01 15:13:39 +0000] information/WorkQueue: Icinga/icingadb-web#6 (InfluxdbWriter, influxdb) items: 0, rate:  0/s (0/min 0/5min 0/15min);
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 106205 Notifications.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 IcingaApplication.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 10698 Dependencies.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 15 HostGroups.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 10474 Hosts.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 FileLogger.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 118 Downtimes.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 SyslogLogger.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 28 Comments.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 CheckerComponent.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 InfluxdbWriter.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 3 Zones.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 2 IdoPgsqlConnections.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 6 Endpoints.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 2 ApiUsers.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 ApiListener.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 177 CheckCommands.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 1 UserGroup.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 15 ServiceGroups.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 15 Users.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 251208 Services.
[2022-07-01 15:13:41 +0000] information/ConfigItem: Instantiated 3 NotificationCommands.
[2022-07-01 15:13:41 +0000] information/ScriptGlobal: Dumping variables to file '/var/cache/icinga2/icinga2.vars'
[2022-07-01 15:13:41 +0000] information/cli: Finished validating the configuration file(s).
Mikesch-mp commented 2 years ago

Module is not yet made for icingadb