search

Mikescops / git-notify-extension

🦊🐙 Browser Extension for GitLab (Chrome, Edge & Firefox). Don't miss any Gitlab Merge Requests and rocket up your productivity.
https://addons.mozilla.org/en-US/firefox/addon/gitlab-notify/
115 stars 10 forks source link

Fix error when there are no reviewers in GitLab's response #41

Closed joshchoo closed 3 years ago

joshchoo commented 3 years ago

I encountered the following error and noticed that GitLab didn't return an array of reviewers from the merge requests API. Mark the reviewers property as optional.

error
Mikescops commented 3 years ago

Oh thanks, I completely forgot that some GitLab instances my not be up to date, thanks for spotting this and for the PR!

Mikescops commented 3 years ago

I pushed the hotfix on Firefox and it's under review for Chrome.

joshchoo commented 3 years ago

Thanks for the quick merge!