search

Mikescops / git-notify-extension

🦊🐙 Browser Extension for GitLab (Chrome, Edge & Firefox). Don't miss any Gitlab Merge Requests and rocket up your productivity.
https://addons.mozilla.org/en-US/firefox/addon/gitlab-notify/
115 stars 10 forks source link

Under review MRs are shown as approved and rdy to be merge (but they aren't 🤦🏼) #47

Closed mathieucollet closed 1 year ago

mathieucollet commented 3 years ago

I don't know if this is a real problem or if it's expected, but the extension tells me that all merge requests (in the "under review" tab) are approved and ready to be merged, even if they are not.

image

image

Mikescops commented 3 years ago

Hello,

Thanks for the report, I've seen the same thing lately.

I think that the green check mark refers to the fact that the branch is merge-able (there is no conflict) but it's not taking in account pipelines nor unresolved threads.

It's clearly misleading so let's make it more accurate or adapt the wording.