Mikescops / git-notify-extension

🦊🐙 Browser Extension for GitLab (Chrome, Edge & Firefox). Don't miss any Gitlab Merge Requests and rocket up your productivity.
https://addons.mozilla.org/en-US/firefox/addon/gitlab-notify/
114 stars 10 forks source link

fix(mr-list): remove mrs current user created from requested list #79

Closed bastienGranger closed 1 year ago

bastienGranger commented 1 year ago

On Gitlab you can be the creator of an MR and be tagged as a reviewer and / or an assignee.

Gitlab documentation is not super clear on what exactly is the role of an Assignee. But it compares the Reviewer and the Assignee as: "In comparison to an Assignee, who is directly responsible for creating or merging a merge request, a Reviewer is a team member who may only be involved in one aspect of the merge request, such as a peer review." Thus I think it is not rare that the creator of the MR is also tagged as the Assignee.

This MR filters out from the list of request, MRs created by the user. This generates noise in the "To Review" tab and is redundant information with the "Under Review" tab

I also took the opportunity to slightly improve the removeDuplicateObjectFromArray typings. By adding generic which will infer the output type from the param's type.