search

Mikescops / node-native-keychain

🔐 Node.js native macos keychain module written in Swift
https://www.npmjs.com/package/native-keychain
MIT License
1 stars 1 forks source link

Add "account" to get/set/delete #4

Open hildjj opened 1 week ago

hildjj commented 1 week ago

Is your feature request related to a problem? Please describe.

A single service can store multiple passwords, each with a different "Account".

Describe the solution you'd like It would be great if "account" could be added to SetPasswordParams, GetPasswordParams, and DeletePasswordParams, then passed through the FFI to the Swift code.

Describe alternatives you've considered I've looked at a bunch of other libraries, but I think this one is closest to what I need.

Additional context

Create password with setPassword({service: 'NAAATIVE', password: 'password'}). Look in Keychain Access for 'NAAATIVE', and you'll see an entry with no Account name.

Mikescops commented 1 week ago

Hello,

Thanks for the suggestion, I don't have much time those days, but I'll definitely take a look at this asap.

Ping me again if I forgot.

hildjj commented 1 week ago

I went ahead and put together a PR for you. I tried to make it as non-invasive as possible, but I did do an update to the dependencies.