MikhailKravets / mkdocs_puml

Inline PlantUML diagrams in your MkDocs documentation
MIT License
26 stars 5 forks source link

The access of the PlantUML doesn't work due to the self-signed certificate of my company. #26

Closed pur-jus closed 2 months ago

pur-jus commented 1 year ago

Describe the bug The access of the PlantUML doesn't work due to the self-signed certificate of my company.

To Reproduce Steps to reproduce the behavior:

  1. Include the plantuml plugin within the mkdocs YAML
    plugins:
    - plantuml:
        puml_url: https://www.plantuml.com/plantuml/
        num_workers: 8
  2. Run mkdocs serve
  3. The following error is displayed
    SSLError: HTTPSConnectionPool(host='www.plantuml.com', port=443): Max retries exceeded with url: /plantuml/svg/ut8eBaaiAYdDpU5oLD2rKt2oKW0BA6GavgKKPoHcft8vWSGThHIIS_ABKv747LBpKa3w00== (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:992)')))

Desktop:

MikhailKravets commented 1 year ago

Hi @pur-jus, thanks for raising an issue. I'll research this one in the near future. As a current workaround I may suggest you to run PlantUML with Docker

MikhailKravets commented 1 year ago

Hi @pur-jus, could you please take a look whether bare requests package can make a request to PlantUML?

ravikumar2026 commented 12 months ago

@MikhailKravets anyway we can disable ssl verification ?

MikhailKravets commented 12 months ago

Yes, it is possible, as stated in requests docs. And the solution is very simple. We need to add a new parameter (for example, verify_ssl: true) to mkdocs.yaml and read it in the plugin.

RishabhDev42 commented 3 months ago

Hey @MikhailKravets , as per this commit, the ability to set ssl verification as false has been rolled back. Could you help me understand why so?

MikhailKravets commented 3 months ago

Hi @RishabhDev42, I believe it was just a human error. I don't see any particular reason for its removal. Thanks for bringing this up! I'll add it to the project with the next release.

MikhailKravets commented 2 months ago

This feature was added in #37. Closing the issue.