Mikotwa / FuckLocation

A simple xposed module that helps you fully control your location.
https://github.com/Xposed-Modules-Repo/fuck.location
GNU Affero General Public License v3.0
336 stars 72 forks source link

Allow negative number in coordinates #9

Closed zypA13510 closed 2 years ago

zypA13510 commented 2 years ago

Negative numbers should be allowed to select locations in the southern/western hemisphere.

Note: I didn't test this change. I'm not really an Android developer and I don't have the development environment to do this. Though I did check the Kotlin code, and it doesn't impose any additional restrictions there, so it should be working (to the best of my knowledge).

Reference: https://stackoverflow.com/q/5061261/5532169

ThePieMonster commented 2 years ago

Glad someone else mentioned this as well. https://github.com/Mikotwa/FuckLocation/issues/8

Mikotwa commented 2 years ago

Thanks for pulling this request. Will merge soon.

zypA13510 commented 2 years ago

@Mikotwa One small thing: I suggest you should tag your releases in Git history, easier to find the source code of a specific version. Better yet, you can configure a pipeline to automate the release for you.