search

Miksus / red-bird

Repository Patterns for Python
https://red-bird.readthedocs.io
MIT License
163 stars 22 forks source link

fix: Unpassed attributes #35

Open Miksus opened 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 90.52% // Head: 90.55% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (49ba55c) compared to base (c0c8560). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ========================================== + Coverage 90.52% 90.55% +0.02% ========================================== Files 16 16 Lines 1024 1027 +3 ========================================== + Hits 927 930 +3 Misses 97 97 ``` | [Impacted Files](https://codecov.io/gh/Miksus/red-bird/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [redbird/base.py](https://codecov.io/gh/Miksus/red-bird/pull/35/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cmVkYmlyZC9iYXNlLnB5) | `88.67% <100.00%> (+0.21%)` | :arrow_up: | | [redbird/repos/csv.py](https://codecov.io/gh/Miksus/red-bird/pull/35/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cmVkYmlyZC9yZXBvcy9jc3YucHk=) | `97.53% <100.00%> (ø)` | | | [redbird/repos/mongo.py](https://codecov.io/gh/Miksus/red-bird/pull/35/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cmVkYmlyZC9yZXBvcy9tb25nby5weQ==) | `90.00% <100.00%> (ø)` | | | [redbird/repos/rest.py](https://codecov.io/gh/Miksus/red-bird/pull/35/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cmVkYmlyZC9yZXBvcy9yZXN0LnB5) | `89.47% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Miksus commented 1 year ago

On the second hand, not sure if this should be implemented. We probably want defaults to end up with the data in the repository.