Closed marksmayo closed 1 year ago
Thanks! There are quite a lot of cleaning to be done. At some point I think Flake8 or other style validators should be added to the CI and this sort of PRs will lessen the burden a lot.
I don't feel great at the moment so I'll check and merge this PR later.
Base: 95.51% // Head: 95.23% // Decreases project coverage by -0.27%
:warning:
Coverage data is based on head (
0b0765d
) compared to base (a8e509b
). Patch coverage: 95.72% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The codecov/project "failed" but I think that's nothing concerning. The failure is due to some unnecessary lines being removed. I cannot see any problems with this: the relevant import paths are the same and all tests pass. Also, the test coverage is still over 95%.
Thanks again for the contribution! This is very helpful.
Using pylint, I've fixed all instances of newlines missing, spaces, and imports. All tests pass (1625/1625).