Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.25k stars 105 forks source link

Clean up of code with pylint. #112

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

Using pylint, I've fixed all instances of newlines missing, spaces, and imports. All tests pass (1625/1625).

Miksus commented 1 year ago

Thanks! There are quite a lot of cleaning to be done. At some point I think Flake8 or other style validators should be added to the CI and this sort of PRs will lessen the burden a lot.

I don't feel great at the moment so I'll check and merge this PR later.

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.51% // Head: 95.23% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (0b0765d) compared to base (a8e509b). Patch coverage: 95.72% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #112 +/- ## ========================================== - Coverage 95.51% 95.23% -0.28% ========================================== Files 88 79 -9 Lines 4612 4322 -290 ========================================== - Hits 4405 4116 -289 + Misses 207 206 -1 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/\_setup.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvX3NldHVwLnB5) | `100.00% <ø> (ø)` | | | [rocketry/conditions/task/utils.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29uZGl0aW9ucy90YXNrL3V0aWxzLnB5) | `90.12% <ø> (-0.47%)` | :arrow_down: | | [rocketry/conds/\_\_init\_\_.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29uZHMvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | | | [rocketry/core/time/\_\_init\_\_.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90aW1lL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [rocketry/core/utils/meta.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS91dGlscy9tZXRhLnB5) | `100.00% <ø> (ø)` | | | [rocketry/exc.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvZXhjLnB5) | `100.00% <ø> (ø)` | | | [rocketry/log/defaults.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvbG9nL2RlZmF1bHRzLnB5) | `100.00% <ø> (ø)` | | | [rocketry/log/handlers.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvbG9nL2hhbmRsZXJzLnB5) | `100.00% <ø> (ø)` | | | [rocketry/parse/time.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvdGltZS5weQ==) | `100.00% <ø> (ø)` | | | [rocketry/parse/utils/parser.py](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvdXRpbHMvcGFyc2VyLnB5) | `100.00% <ø> (ø)` | | | ... and [76 more](https://codecov.io/gh/Miksus/rocketry/pull/112/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Miksus commented 1 year ago

The codecov/project "failed" but I think that's nothing concerning. The failure is due to some unnecessary lines being removed. I cannot see any problems with this: the relevant import paths are the same and all tests pass. Also, the test coverage is still over 95%.

Thanks again for the contribution! This is very helpful.