Pylint if/elif/else, returns and isinstance comparisons

Miksus / rocketry

Modern scheduling library for Python

https://rocketry.readthedocs.io

MIT License

3.25k stars 105 forks source link

Pylint if/elif/else, returns and isinstance comparisons #120

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

Some more pylint stuff, cleaning up unnecessarily complex if/elif/else branches, and overly complex boolean / instance comparisons. Hope it helps. I'm unsure how to trigger the code coverage you did last time.

Miksus commented 1 year ago

Sorry been a bit busy. I'll check this next weekend at the latest.

Thanks again for cleaning the project! This is well appreciated.

marksmayo commented 1 year ago

No hurry or worries, I'm learning a lot by working through these, and hopefully they're somewhat useful.

Miksus commented 1 year ago

Sorry for taking eternity with this, got distracted with learning about event-driven design (in order to make Rocketry to support its patterns).

I'll try to merge this today evening.

Miksus commented 1 year ago

Thanks again for the PR! Looks indeed good and especially the tests previously had some really odd patterns.