Closed marksmayo closed 1 year ago
Sorry been a bit busy. I'll check this next weekend at the latest.
Thanks again for cleaning the project! This is well appreciated.
No hurry or worries, I'm learning a lot by working through these, and hopefully they're somewhat useful.
Sorry for taking eternity with this, got distracted with learning about event-driven design (in order to make Rocketry to support its patterns).
I'll try to merge this today evening.
Thanks again for the PR! Looks indeed good and especially the tests previously had some really odd patterns.
Some more pylint stuff, cleaning up unnecessarily complex if/elif/else branches, and overly complex boolean / instance comparisons. Hope it helps. I'm unsure how to trigger the code coverage you did last time.