Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.25k stars 105 forks source link

pylint fstrings and more #127

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

Some more tidy-ups with f-strings, uneeded vars, simplified additions and encodings.

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.21% // Head: 94.72% // Decreases project coverage by -0.49% :warning:

Coverage data is based on head (ad35cfd) compared to base (7c8c877). Patch coverage: 97.22% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #127 +/- ## ========================================== - Coverage 95.21% 94.72% -0.50% ========================================== Files 79 79 Lines 4327 4323 -4 ========================================== - Hits 4120 4095 -25 - Misses 207 228 +21 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/conditions/task/task.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29uZGl0aW9ucy90YXNrL3Rhc2sucHk=) | `92.94% <ø> (+0.54%)` | :arrow_up: | | [rocketry/parse/\_condition/condition\_item.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvX2NvbmRpdGlvbi9jb25kaXRpb25faXRlbS5weQ==) | `100.00% <ø> (ø)` | | | [rocketry/pybox/time/\_\_init\_\_.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcHlib3gvdGltZS9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [rocketry/core/task.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90YXNrLnB5) | `90.49% <75.00%> (-2.89%)` | :arrow_down: | | [rocketry/application.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [rocketry/core/condition/base.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9jb25kaXRpb24vYmFzZS5weQ==) | `99.42% <100.00%> (ø)` | | | [rocketry/core/parameters/parameters.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9wYXJhbWV0ZXJzL3BhcmFtZXRlcnMucHk=) | `96.90% <100.00%> (ø)` | | | [rocketry/core/schedule.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9zY2hlZHVsZS5weQ==) | `92.92% <100.00%> (+0.30%)` | :arrow_up: | | [rocketry/core/time/anchor.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90aW1lL2FuY2hvci5weQ==) | `92.39% <100.00%> (-0.05%)` | :arrow_down: | | [rocketry/core/utils/pickle.py](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS91dGlscy9waWNrbGUucHk=) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/Miksus/rocketry/pull/127/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Miksus commented 1 year ago

Thanks again for the contribution! By the way, how are you using Pylint? I'm thinking of adding some linters (ie. using Flake8) to the CI to keep the code tidy in the future as well.

marksmayo commented 1 year ago

I do it in two ways - on the command line (pylint_runner is a handy wrapper for it, and with -d options to hide ones I'm not trying to fix), and in VSCode where you edit the user settings.json file and hide the ones you don't want to see as well.

marksmayo commented 1 year ago

You can add it as a Github action, and just -d the ones that currently exist as issues, thus preventing any new ones from being added at least?