Closed djnnvx closed 1 year ago
Thanks a lot for the contribution! I think this will be very helpful for many. Getting late and cannot properly function this late but I'll check during the next week if that's fine. I'm also working on the event mechanism which is quite an interesting feature.
I think this needs to be added to the cookbook index.rst. Do you want to do it or do mind you if I add it?
Base: 94.90% // Head: 94.90% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
ec8865e
) compared to base (9a53ad6
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hmm, it seems the docs building is not in CI for some reason but I think the docs generation fails due to the page missing in index.rst, but I'll also check it in the upcoming days 👍
If you wish to try to generate the docs:
pip install tox
tox -e docs
Then those should be in the docs/_build/html/...
Thanks, i'll fix it in the afternoon.
Hi, did you have any chance to look at this ?
Hi, sorry, been quite busy recently. My days are quite full this week (including a bit of work on Saturday). Perhaps on Sunday evening I could have time to check and merge, or on Monday evening latest.
I'll also try to change the wording and correct some minor typos a bit in some places later today/tomorrow if you don't mind.
I'll get it done by the end of the week. I'm taking some time off right now, for personal reasons. But I will get it done, no problem
Don't worrying about it 🙂 you are contributing to open-source so I expect you to do it when you are on the mood for it. I'm not in hurry and Rocketry is a marathon.
To be honest, I haven't been in good mood for the past two weeks but hopefully I also get back on track this week.
This should be OK now, feel free to add any changes to wording or coding style. Please let me know if there is anything else I can do to make it better.
Sorry for being lazy (to be honest, I had a self-inflicted headache yesterday). Unfortunately, it seems the next three days will go with hobbies (and today feeling quite tired) but hopefully on Friday I have time the latest, or in the weekend.
No worries at all, take your rest and stay safe.
Sorry, I broke my promise and just was too interested in side projects. I scheduled time on Sunday at 10:00 (EET) to check this finally out.
Perhaps I should have a recurrent timeslot in my calendar to check Rocketry's issues and PRs to have some structure on handling those and avoid forgetting.
No worries, this is not very urgent. Take your time and enjoy your passion projects!
Yep, I think this is fine. I spotted an extra space but I don't think that's bad enough not to approve (I can fix those myself if you don't mind). 👍
As said, I'm not a Django expert so if there are things to fix, let's handle it as a community :)
And by the way, I'll add your name to the new contributors.md if you don't mind.
Thanks, that's very cool. You said you were working on an event mechanism ? Maybe I could add some docs regarding that as well, if you'd like.
As promised in #125, here is the cookbook with my basic setup for Django.
It also contains a little remark regarding Django's async ORM, as I've had issues making it work at first.
Please let me know if anything is superfluous or missing, or if there is anything I can do to improve this PR.
thanks :)~