More pylint fixes

[marksmayo]

Including some newly introduced ones when I rebased

[Miksus]

Thanks! I'll try to check and merge before the end of the week. Sorry for the delay.

[Miksus]

Sorry it took almost a month to review (had a bad week, a busy week and a small side project). I think all of those changes are appropriate but I think some of those placehoder ... could be left in the snippets in the docs.

That contribution.md is also a nice addition. Perhaps will motivate others to do an excellent work for the library just as you have done :) Though I would emphasise your fixes role more as you have significantly cleaned up the code base.

[codecov-commenter]

Codecov Report

Base: 94.88% // Head: 94.90% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (49528b0) compared to base (7765b53). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #133 +/- ## ========================================== + Coverage 94.88% 94.90% +0.02% ========================================== Files 80 80 Lines 4454 4454 ========================================== + Hits 4226 4227 +1 + Misses 228 227 -1 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/parse/\_setup\_cond\_parsers.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvX3NldHVwX2NvbmRfcGFyc2Vycy5weQ==) | `100.00% <ø> (ø)` | | | [rocketry/args/builtin.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvYXJncy9idWlsdGluLnB5) | `98.50% <100.00%> (ø)` | | | [rocketry/conditions/api.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29uZGl0aW9ucy9hcGkucHk=) | `98.36% <100.00%> (ø)` | | | [rocketry/conditions/task/task.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29uZGl0aW9ucy90YXNrL3Rhc2sucHk=) | `93.87% <100.00%> (ø)` | | | [rocketry/core/schedule.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9zY2hlZHVsZS5weQ==) | `93.50% <100.00%> (+0.36%)` | :arrow_up: | | [rocketry/core/task.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90YXNrLnB5) | `91.41% <100.00%> (ø)` | | | [rocketry/log/log\_record.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvbG9nL2xvZ19yZWNvcmQucHk=) | `100.00% <100.00%> (ø)` | | | [rocketry/session.py](https://codecov.io/gh/Miksus/rocketry/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvc2Vzc2lvbi5weQ==) | `95.72% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[marksmayo]

Still says changes requested but I think I've resolved all? Just pulling in latest from your repo to see if I've missed any new ones

[Miksus]

Yep, looks good. Thanks again for the fixes and sorry for the immense delay. I now booked an hour every week to go through PRs and issues so hopefully, there won't be the same delay anymore.

[marksmayo]

All good. I'm still learning so in no hurry.