Closed marksmayo closed 1 year ago
Thanks! I'll try to check and merge before the end of the week. Sorry for the delay.
Sorry it took almost a month to review (had a bad week, a busy week and a small side project). I think all of those changes are appropriate but I think some of those placehoder ...
could be left in the snippets in the docs.
That contribution.md is also a nice addition. Perhaps will motivate others to do an excellent work for the library just as you have done :) Though I would emphasise your fixes role more as you have significantly cleaned up the code base.
Base: 94.88% // Head: 94.90% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
49528b0
) compared to base (7765b53
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Still says changes requested but I think I've resolved all? Just pulling in latest from your repo to see if I've missed any new ones
Yep, looks good. Thanks again for the fixes and sorry for the immense delay. I now booked an hour every week to go through PRs and issues so hopefully, there won't be the same delay anymore.
All good. I'm still learning so in no hurry.
Including some newly introduced ones when I rebased