Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.25k stars 105 forks source link

cleaned up imports, converted f-strings #148

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

Where possible I converted all old-style format strings to f-strings Also ran isort to sort the imports, however had to undo a couple due to cyclic imports causing problems. Might be worth a look.

Quite a lot of files but the tests do all pass and it's relatively logical.

Of note is that a test in test_core.py and two tests in test_compare.py intermittently fail. Presume timing issue, I've seen them pass for sure.

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.88% // Head: 94.89% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (0166d13) compared to base (2348c90). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #148 +/- ## ========================================== + Coverage 94.88% 94.89% +0.01% ========================================== Files 80 80 Lines 4454 4449 -5 ========================================== - Hits 4226 4222 -4 + Misses 228 227 -1 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/args/builtin.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvYXJncy9idWlsdGluLnB5) | `98.50% <ø> (ø)` | | | [rocketry/args/secret.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvYXJncy9zZWNyZXQucHk=) | `94.44% <ø> (ø)` | | | [rocketry/core/utils/pickle.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS91dGlscy9waWNrbGUucHk=) | `100.00% <ø> (ø)` | | | [rocketry/core/utils/process.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS91dGlscy9wcm9jZXNzLnB5) | `100.00% <ø> (ø)` | | | [rocketry/log/defaults.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvbG9nL2RlZmF1bHRzLnB5) | `100.00% <ø> (ø)` | | | [rocketry/log/log\_record.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvbG9nL2xvZ19yZWNvcmQucHk=) | `100.00% <ø> (ø)` | | | [rocketry/parameters/func.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyYW1ldGVycy9mdW5jLnB5) | `100.00% <ø> (ø)` | | | [rocketry/parse/\_time/time\_item.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvX3RpbWUvdGltZV9pdGVtLnB5) | `100.00% <ø> (ø)` | | | [rocketry/parse/time.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcGFyc2UvdGltZS5weQ==) | `100.00% <ø> (ø)` | | | [rocketry/pybox/container/visitor.py](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvcHlib3gvY29udGFpbmVyL3Zpc2l0b3IucHk=) | `84.05% <ø> (ø)` | | | ... and [51 more](https://codecov.io/gh/Miksus/rocketry/pull/148/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Miksus commented 1 year ago

Sorry for taking time again, was busy coming up with the next release. I made quite a significant update on the packaging making the release quite a breeze (actually it's pretty awesome; now I just need to make a tag, push it to GitHub and the release is automatically built and sent to PyPI).

Probably will go to the next release but I'll check this next week if you don't mind :)

Miksus commented 1 year ago

Oh, sorry. It seems that my this weekend PR marathon also introduced quite a lot of conflicts to your PR...

marksmayo commented 1 year ago

Oof, yes, quite a few. Also I don't seem to have access to the 'resolve conflicts' button. :/ I'll have a look later, might just redo it