Closed marksmayo closed 1 year ago
Base: 94.88% // Head: 94.89% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
0166d13
) compared to base (2348c90
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sorry for taking time again, was busy coming up with the next release. I made quite a significant update on the packaging making the release quite a breeze (actually it's pretty awesome; now I just need to make a tag, push it to GitHub and the release is automatically built and sent to PyPI).
Probably will go to the next release but I'll check this next week if you don't mind :)
Oh, sorry. It seems that my this weekend PR marathon also introduced quite a lot of conflicts to your PR...
Oof, yes, quite a few. Also I don't seem to have access to the 'resolve conflicts' button. :/ I'll have a look later, might just redo it
Where possible I converted all old-style format strings to f-strings Also ran isort to sort the imports, however had to undo a couple due to cyclic imports causing problems. Might be worth a look.
Quite a lot of files but the tests do all pass and it's relatively logical.
Of note is that a test in test_core.py and two tests in test_compare.py intermittently fail. Presume timing issue, I've seen them pass for sure.