Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.25k stars 105 forks source link

BUG: Cache before startup #155

Closed Miksus closed 1 year ago

Miksus commented 1 year ago

This PR fixes the issue with incorrect cache if repo is changed with app.startup.

Also, the cache init is now at session start and not at the task init.

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.34% // Head: 95.36% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (75ce6c9) compared to base (c69e7eb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #155 +/- ## ========================================== + Coverage 95.34% 95.36% +0.01% ========================================== Files 80 80 Lines 4643 4656 +13 ========================================== + Hits 4427 4440 +13 Misses 216 216 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/core/schedule.py](https://codecov.io/gh/Miksus/rocketry/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9zY2hlZHVsZS5weQ==) | `93.61% <100.00%> (+0.13%)` | :arrow_up: | | [rocketry/core/task.py](https://codecov.io/gh/Miksus/rocketry/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90YXNrLnB5) | `92.24% <100.00%> (+0.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.