codecov-commenter
commented
1 year ago Codecov Report
Base: 95.36% // Head: 95.36% // No change to project coverage :thumbsup:
Coverage data is based on head (
2fae76a) compared to base (7dbd1c0). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #160 +/- ## ======================================= Coverage 95.36% 95.36% ======================================= Files 80 80 Lines 4660 4660 ======================================= Hits 4444 4444 Misses 216 216 ``` | [Impacted Files](https://codecov.io/gh/Miksus/rocketry/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli) | Coverage Δ | | |---|---|---| | [rocketry/core/schedule.py](https://codecov.io/gh/Miksus/rocketry/pull/160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS9zY2hlZHVsZS5weQ==) | `93.63% <100.00%> (+0.02%)` | :arrow_up: | | [rocketry/core/task.py](https://codecov.io/gh/Miksus/rocketry/pull/160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli#diff-cm9ja2V0cnkvY29yZS90YXNrLnB5) | `92.23% <100.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mikael+Koli):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This should fix the issue with #144.
The issue was caused by that the run stack was never cleaned and the termination check included finished runs. Fixed by cleaning the run stack periodically and also now it should not terminate finished runs.