search

Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.27k stars 106 forks source link

ENH: Add github actions for pylint #165

Open marksmayo opened 1 year ago

marksmayo commented 1 year ago

Is your feature request related to a problem? Please describe. It'd be nice to gradually fix and turn on pylint errors (and maybe latest flake8/black checks). Having it as part of build CI/CD with github actions would help prevent increase of these.

Describe the solution you'd like Add github actions for pylint eg https://github.com/marketplace/actions/github-action-for-pylint Turn on initially with -ignore for

R0401,R0801,C0112,C0113,C0114,C0115,C0116,C0301,C0103,W0511,E0602,E1101,E1102,E0001,W2301,W0613,E0102,R0914,R0912,R1732,E0213,W0212,W0108,E1125,E0704,R0903,W0622,R0913,C0415,E0611,W0707,W0642,R1710,W0703,R0913,W0106,W0223,W0221,C0412,W0201,,R0904,R1704,E0601,R0902,W0236,W0612,W0611,W0143,W0109,W0231,W0621,W0107,W0104,W0621,E1121,W0706,W0122,R0915,W0631,C0302,E0401

and then can slowly remove those as the project quality improves.

Describe alternatives you've considered Also might be worth considering black and / or flake8

Additional context A measure of code quality

tekumara commented 1 year ago

If you haven't already committed to a linter I recommend checking out https://github.com/charliermarsh/ruff .. super fast, fully-featured (covers a range of checks beyond pylint) and the maintainers are very responsive to feedback. I'm a very happy user of ruff on my projects!