Miksus / rocketry

Modern scheduling library for Python

https://rocketry.readthedocs.io

MIT License

3.26k stars 105 forks source link

testing pydantic v1.10.0a2 #86

Closed samuelcolvin closed 2 years ago

samuelcolvin commented 2 years ago

TO NOT MERGE

This is pull request is just to test pydantic v1.10, see https://github.com/pydantic/pydantic/discussions/4359

samuelcolvin commented 2 years ago

Hi, please can you kick off tests so I can check if v1.10 will break anything.

codecov-commenter commented 2 years ago

Codecov Report

Merging #86 (7bc8754) into master (7584cb1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          88       88           
  Lines        4368     4368           
=======================================
  Hits         3981     3981           
  Misses        387      387

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Miksus commented 2 years ago

Yep, runned. Seems at least that my tests are fine with the new Pydantic version, @samuelcolvin

samuelcolvin commented 2 years ago

that's great, thanks so much.