Miksus / rocketry

Modern scheduling library for Python
https://rocketry.readthedocs.io
MIT License
3.26k stars 105 forks source link

FIX: TimeOfMinute subseconds #91

Closed Miksus closed 2 years ago

Miksus commented 2 years ago

There was a bug in TimeOfMinute subseconds. Also the minutely condition did not work correctly for subseconds as well.

For example these did not work:

Additional changes:

codecov-commenter commented 2 years ago

Codecov Report

Merging #91 (1ad057e) into master (2413a22) will increase coverage by 0.13%. The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   91.44%   91.57%   +0.13%     
==========================================
  Files          89       89              
  Lines        4488     4500      +12     
==========================================
+ Hits         4104     4121      +17     
+ Misses        384      379       -5     
Impacted Files Coverage Δ
rocketry/time/interval.py 98.45% <92.85%> (+2.15%) :arrow_up:
rocketry/core/time/anchor.py 88.76% <100.00%> (+1.04%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.