removed "Setup Python" and "Setup Java 11"

MikuAuahDark / love-fuser

Packages LÖVE Games using GitHub Actions

16 stars 3 forks source link

removed "Setup Python" and "Setup Java 11" #2

Closed ghost closed 2 years ago

ghost commented 2 years ago

Because "window-latest"( Microsoft Windows Server 2019 ) and "Ubuntu 18.04.6 LTS" already comes with python and java 11 pre-installed

ghost commented 2 years ago

However Only the Linux Workflow fails after removing "Setup Python" because of this error:

File "game/scripts/download_deps_linux.py", line 4
    def run_command(command: str):
                           ^
SyntaxError: invalid syntax
Error: Process completed with exit code 1.

MikuAuahDark commented 2 years ago

The Python script is written for Python 3.9 in mind. That setup-python line ensure it uses Python 3.9 or later (and as you notice in Linux, it may ship Python 3.7 which doesn't support type hinting hence the error you saw). For the setup-java 11, I'm not gonna remove it because it won't hurt.