Mikusch / deathrun

A highly customizable Deathrun plugin for Team Fortress 2
GNU General Public License v3.0
20 stars 9 forks source link

Needs an option for no fall damage like deathrun redux. #21

Closed gdfsgdfg closed 2 years ago

gdfsgdfg commented 2 years ago

Ditto.

worMatty commented 2 years ago

Which maps is this needed for?

gdfsgdfg commented 2 years ago

Simulation is a recent popular one that compensates by having health packs scattered around practically forcing low health classes to go for them unlike neonoir that just disables fall damage with the map itself.

Obviously fall damage is not enough kill you in most dr maps, but its a nice option.

gdfsgdfg commented 2 years ago

Also I have a question what to set dr_speed_modifier to, I set it to 300.0 which is supposed to be pyro's speed. But that's not the case since it makes everyone go at super speeds. I've set it at 100.0 which seems almost right.

Mikusch commented 2 years ago

I don't know whether I really want to add this, but it's something I'll keep in mind. Usually it's on the map to enable or disable fall damage where necessary. I'd argue that a map containing health kits was built with fall damage in mind, thus it should not be disabled.

Also I have a question what to set dr_speed_modifier to, I set it to 300.0 which is supposed to be pyro's speed. But that's not the case since it makes everyone go at super speeds. I've set it at 100.0 which seems almost right.

It's a modifier, not an absolute value. Setting dr_speed_modifier to 300 will add 300 speed to all classes. Setting it to -50 will remove 50 speed from all classes, and so on. I always deal with modifiers rather than absolute values because there is a chance Valve might change these values in the future.

If you want to set every class' speed to 300, you'll have to use the dr_speed_modifier_scout, dr_speed_modifier_soldier, etc. convars to remove or add the appropriate value to everyone.

worMatty commented 2 years ago

I understand your frustration about fall damage but I cam concerned that adding the ability to disable it to a deathrun plugin will cause server operators to disable it for all deathrun maps. This is bad because it prevents deathrun maps from using fall damage as part of their design and it can cause mappers to believe that fall damage will always be disabled and that they should not deal with it in their map. Deathrun plugins have a history of disabling things because of flawed maps and it limits what mappers can do as a result.

I suggest you contact the map author and leave feedback on their design choice. If the fall damage is unavoidable, I believe that's not fair and that the fall damage should be prevented in that case rather than need healing (maybe it's due to the mapper's lack of knowledge?). However if the fall damage is avoidable (for example by taking a longer route), that is arguably a design decision that shouldn't be interfered with.

gdfsgdfg commented 2 years ago

Redux always reverted all changes it did if it detected a non-dr map. Anyway you're kinda making no sense there, miku's bhop plugin has a toggle to disable fall damage as well. My server config has a unload for the deathrun plugin and "maps with prefixes" plugin on dr to enable it from the disabled folder and works just fine when swapping to other maps and game modes.

Anyway for those that are lazy like me and want 300 hu/s on all classes like older dr use these settings.

dr_speed_modifier_scout -100.0 dr_speed_modifier_soldier 60.0 dr_speed_modifier_demoman 20.0 dr_speed_modifier_medic -20.0 dr_speed_modifier_heavy 70.0 dr_speed_modifier_spy -20.0

worMatty commented 2 years ago

My apologies if I misled you but I was talking about all deathrun maps. I did not think it would be necessary to specify that. I will edit my post.

gdfsgdfg commented 2 years ago
// Pyro - Melee [Slot 3]
"214"   // The Powerjack
{
    "attributes"
    {
        "1"
        {
            "name"  "move speed bonus"
            "value" "1.0"
        }
    }
}

Also added this so no speed boost from power jack.

gdfsgdfg commented 2 years ago

I also noticed that you can't spectate death either, would like that to be an option as well.

Mikusch commented 2 years ago

mp_forcecamera exists

gdfsgdfg commented 2 years ago

Neat, I'll use that.

I'll close this for now since I found a fall damage related plugin, hopefully doesn't make more side effects..