Open PawlikMichal25 opened 10 months ago
@Milad-Akarie Bumping this, it would be nice to be able to specify push/navigate, or just make constructors public. Also, having all the different DeepLink implementations private makes it very inconvenient to test. I want to write some unit tests to make sure my deepLinkBuilder is returning correct links, but cannot access any of the fields in the return value.
@Milad-Akarie can this be fixed so its possible to pick wether to navigate/push RouteDeeplinks
Problem
We're using AutoTabsScaffold with following configuration:
and when user clicks deep link to nested tab, then we return eg.
DeepLink([OrdersRoute()])
indeepLinkBuilder
. This opens a new MainPage with OrdersRoute, which means that user ends up with 2 MainPages.Possible solution
I think the easiest solution would be to return
PlatformDeepLink([OrdersRoute()])
so that here https://github.com/Milad-Akarie/auto_route_library/blob/master/auto_route/lib/src/router/controller/auto_router_delegate.dart#L171.navigateX()
is used instead of.pushX()
, but PlatformDeepLink has private constructor.@Milad-Akarie, would you please consider:
PlatformDeepLink
public so that developers can still rely onnavigateX()
when parsing DeepLinks by themselves?