Milad-Akarie / form_field_validator

MIT License
121 stars 29 forks source link

Email Validator should be case-insensitive #4

Open VishnuPrabhu opened 4 years ago

VishnuPrabhu commented 4 years ago

validating the string code>mail@GMAIL.com</code is failing, because of case sensitive.

Milad-Akarie commented 4 years ago

Hey @VishnuPrabhu mail providers don't actually care about case sensitivity so this's actually a valid email address.

VishnuPrabhu commented 4 years ago

Hi @Milad-Akarie , yes thats the expected. But actually, it is throwing error for above case.

The28AWG commented 3 years ago

are there any fixes?

ayberkcal commented 3 years ago

https://github.com/Milad-Akarie/form_field_validator/blob/4c33b420ea07bf57369a258f006b4f42df7c0ab7/lib/form_field_validator.dart#L126 looks validator is not case sensitive. Can you clone project and run tests? Maybe bug about your local env. This may help to understand what is the behind of problem.

AlexanderFarkas commented 3 years ago

@ayberkcal If you look at source code after getting 1.0.1 v from pub.dev, you can see that there is no "caseSensetive: false" there.

AlexanderFarkas commented 3 years ago

@Milad-Akarie I've specified direct link to git repository, and now everything works fine (there is caseSensitive in the sources). Maybe something is wrong with versioning? And pub.dev cached previous version of the package.

ManojMMWWIndia commented 3 years ago

Problem still persists, Please update the package

AlexanderFarkas commented 3 years ago

@ManojMMWWIndia As a temporary solution add:

form_field_validator:
    git: https://github.com/Milad-Akarie/form_field_validator.git

To pubspec.yaml. Also delete form_field_validator entry from pubspec.lock.