search

Milad-Akarie / pretty_dio_logger

MIT License
221 stars 49 forks source link

Mark `logPrint` as `final` #23

Closed rohan20 closed 1 year ago

rohan20 commented 2 years ago

Faced an issue where I had overriden the setter instead of the getter which led to logging print(..) calls even when I didn't want to do that. Realised that I was even able to access the setter in first place because this field isn't final.

I couldn't find a reason why it needs to be non-final so this PR marks it as final.

image

Milad-Akarie commented 1 year ago

done manually, because there were conflicts, Thanks for the effort.