Milchreis / UiBooster

🚀 Creates fast and easy dialogs for utility tools
GNU General Public License v3.0
117 stars 12 forks source link

Refactor `UiBooster(Options)` emphasizing extensibility #44

Closed KotzaBoss closed 3 years ago

KotzaBoss commented 3 years ago

Extensibility provided through subclassing the now abstract UiBoosterOption class and polymorphically using its subclasses. Attempted to remove hardcoded values and move them into their logical unit (example default loadingImage or iconImage).

Stayed as close as possible to previous UiBoosterOptions API inorder to stay backwards compatible. Attention was given to the construction of UiBooster through the Theme enum.

Milchreis commented 3 years ago

hi @KotzaBoss

thank you very much for your work and explainations. I think it's a very good idea to refactor this code. There are two things I have to think about:

Currently I am not sure how to solve the second point. Do you have any ideas?

KotzaBoss commented 3 years ago

Great that you found it interesting!

Milchreis commented 3 years ago

Great work @KotzaBoss thank you very much for your work and your patience. Now I found some time to check your changes and integrate it into the repo. Your refactoring is very good and makes the code much more readable 👍

KotzaBoss commented 3 years ago

Thats awesome!! Your framework is exactly the type i enjoy working with because it gives you out-of-the-box functionality. My guis dont usually (ever) require design so this shaves hours of work.

Great work!