search

Milchreis / UiBooster

🚀 Creates fast and easy dialogs for utility tools
GNU General Public License v3.0
117 stars 12 forks source link

Bring back support for using a previously set look and feel #65

Closed xDUDSSx closed 2 years ago

xDUDSSx commented 2 years ago

Hello again, I'm not sure what happened, but a while back I created issue #31 about UIBooster essentially always using its own separate look and feel, which I felt is a huge drawback. That got changed but it seems that pull request #44 completely deleted this new functionality.

So, unless I overlooked something, I'm proposing to bring it back in the form of InferredUIBoosterOptions. I'd even opt to make this the default or at least very clear that this is an option. Since, like I said back then, having a consistent look and feel is very important. I suppose making it the default might be too much because you can't know beforehand what laf the user has and hence can't ensure that UIBooster works properly.

But otherwise, any larger application will want UIBooster to use its likely heavily modified laf, not a different one with default settings.

I'm also going to note that the UIBooster constructors look like kind of a mess to me. why was there a DEFAULT theme if DefaultUIBoosterOptions were removed, then it's missing in the enum switch, and why does the Font constructor use it? I changed it so that DEFAULT now means InferredUIBoosterOptions and I left it at that.

Let me know what you think.

Milchreis commented 2 years ago

Hi @xDUDSSx,

thank you very much for your PR and explanation. I will take a closer look in the upcoming week.