MilesChou / docker-phalcon

Dockerized Phalcon
https://hub.docker.com/repository/docker/mileschou/phalcon
MIT License
126 stars 41 forks source link

Add PHP 8.0 support #47

Closed MilesChou closed 1 year ago

MilesChou commented 3 years ago

See https://www.php.net/releases/8.0/en.php

Jeckerson commented 3 years ago

You can already do that. Here is example that we are using for local development: https://github.com/phalcon/cphalcon/blob/master/docker/8.0/Dockerfile

MilesChou commented 3 years ago

Official issue link https://github.com/phalcon/cphalcon/issues/15186

Jeckerson commented 3 years ago

@MilesChou Could you make new Dockerfile's shipped with Phalcon v5.alpha?

MilesChou commented 3 years ago

I try on alpha3

https://github.com/phalcon/cphalcon/tree/v5.0.0alpha3

MilesChou commented 3 years ago

@Jeckerson Compile work but phalcon.so file load failed.

I don't know why because I just a PHP developer.

https://github.com/MilesChou/docker-phalcon/runs/3132198314?check_suite_focus=true#step:3:45868

Jeckerson commented 3 years ago

Try to use safe folder instead of 64bits.

MilesChou commented 3 years ago

Try to use safe folder instead of 64bits.

Use safe folder but same problem again.

https://github.com/MilesChou/docker-phalcon/runs/3157993047?check_suite_focus=true#step:3:45939

MilesChou commented 3 years ago

@Jeckerson Solved. Because load Phalcon extension first by default. Adjust the PSR to first and work on Debian and Alpine.

See commit https://github.com/MilesChou/docker-phalcon/pull/50/commits/053496fdc5994aa13bced30c98f39d1b71c0e27f

Jeckerson commented 2 years ago

@MilesChou Could you bump version to RC1 please? And also add PHP8.1.

MilesChou commented 2 years ago

I tried but build failed...

https://github.com/MilesChou/docker-phalcon/runs/6844355654?check_suite_focus=true

Jeckerson commented 2 years ago

I tried but build failed...

https://github.com/MilesChou/docker-phalcon/runs/6844355654?check_suite_focus=true

Seems to work. Btw PSR extension is not required any more since RC1 version.

MilesChou commented 2 years ago

OK, I update code on 8.0 and 8.1 Dockerfile https://github.com/MilesChou/docker-phalcon/actions/runs/2485532716

Jeckerson commented 1 year ago

@MilesChou it seems that it can be closed.

MilesChou commented 1 year ago

Done, Thx @Jeckerson