search

MilesCranmer / DispatchDoctor.jl

The dispatch doctor prescribes type stability
Apache License 2.0
128 stars 6 forks source link

`@stable` doesn't accept docstrings #13

Closed matthias314 closed 1 month ago

matthias314 commented 1 month ago 
julia> @eval @stable module M

       "doc for f"
       f(x) = x

       end
ERROR: LoadError: MethodError: no method matching matches_incompatible_macro(::GlobalRef)

I'm using the current version https://github.com/MilesCranmer/DispatchDoctor.jl/commit/2dd04aa3e679ca82e93af276b36a7d01879d721a.

So far I've found all bugs I've reported by trying DispatchDoctor out on my package SmallCollections.jl. It seems to be quite effective at revealing problems. Maybe you find it helpful, too.

MilesCranmer commented 1 month ago

Fixed with 0e4de324953592ed43a192bdc653c9ce47f1567b

Thanks for reporting all of them!! I'll have to make it an integration test at some point.

MilesCranmer commented 1 month ago

With https://github.com/MilesCranmer/DispatchDoctor.jl/commit/023cbbc9f5f6bfc9038014c7892e9b2c66bea71e it seems like I fixed all the errors showing up during initial parsing on SmallCollections.jl