MilesCranmer / DispatchDoctor.jl

The dispatch doctor prescribes type stability
Apache License 2.0
138 stars 7 forks source link

Patch Zygote incompatibility with warning #36

Closed MilesCranmer closed 3 months ago

MilesCranmer commented 3 months ago

Fixes #32.

@avik-pal want to take a look?

Also I couldn't get it working with errors. I tried something similar with marking the throw(e) with @ignore_derivative but no luck.

github-actions[bot] commented 3 months ago

Benchmark Results

main b1237fec41a7be... main/b1237fec41a7be...
_stable/mode=disable 0.14 ± 0.00066 ms 0.139 ± 0.00079 ms 1.01
_stable/mode=error 0.808 ± 0.02 ms 0.81 ± 0.018 ms 0.997
_stable/mode=warn 0.803 ± 0.029 ms 0.805 ± 0.028 ms 0.999
time_to_load 0.0678 ± 0.00035 s 0.0674 ± 0.00044 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

coveralls commented 3 months ago

Coverage Status

coverage: 100.0%. remained the same when pulling b1237fec41a7bea69a5efb23328b2c50faedc62f on patch-zygote into 7e37b7f9105d57bfb819b04bbe3ad80d5037fe87 on main.

MilesCranmer commented 3 months ago

Thanks for the help!