search

MilesCranmer / rip2

A safe and ergonomic alternative to rm
GNU General Public License v3.0
27 stars 1 forks source link

Porting PR #40 #6

Closed MilesCranmer closed 2 months ago

MilesCranmer commented 2 months ago

Moving @tmacychen's PR https://github.com/nivekuil/rip/pull/40 to here for merging.

(Will be some conflicts that I will need to solve first)

MilesCranmer commented 2 months ago

@tmacychen I updated this PR to the new codebase.

Question: I am wondering if it is better if we have something like --graveyard=@trash rather than introducing a new flag. What do you think?

Also, we should add some tests (to tests/integration_tests.rs)

MilesCranmer commented 2 months ago

On second thought I wonder if this should just be up to the user. Seems easier to just configure RIP_GRAVEYARD to point at your trash directory?

Let me know otherwise and I can reopen.