search

MilesMcBain / friendlyeval

A friendly interface to tidyeval/rlang that will excuse itself when you're done.
Other
107 stars 6 forks source link

Copyedit README.md for clarity & consistency #5

Closed pkq closed 6 years ago

pkq commented 6 years ago

This pull request includes a number of minor suggestions to improve clarity & consistency within README.md and adds links to rlang, dplyr, the programming with dplyr vignette, & RStudio addins. Hope you find it useful.

MilesMcBain commented 6 years ago

Thankyou so much for this!

Since you've read over it, I'd be interested in your opinion on moving out the functions/operators into an 'Overview' section above the 'Writing functions that call dplyr' section. Need to rework things a little.

pkq commented 6 years ago

You're welcome! I'd be happy to put some thought into how to best organize things. I should have some time in a few hours.

pkq commented 6 years ago

After trying it both ways, I think including an 'Overview' makes good sense. I just pushed another commit that makes those changes, along with rephrasing a few other things. Take a look and let me know what you think. I'm really excited about the potential of this package to help ease folks into the world of tidyeval!

MilesMcBain commented 6 years ago

I was just asking for an opinion! The fact you went and did it is awesome, and as I suspected it has worked out well. Thank you. I am stoked with how this is turning out.

pkq commented 6 years ago

As am I! Let me know if you need another set of eyes on anything else.

MilesMcBain commented 6 years ago

There's a couple of little things that need to be fixed in this, but I'm so happy with it I'm going to merge it and use it as the basis.

Re other todos, there's harmonising all the documentation for the functions with our new explanation.

pkq commented 6 years ago

Fantastic! There's also the small issue of actually renaming the functions themselves, correct?

MilesMcBain commented 6 years ago

I think I have done the renames. It's getting the doco and tests up to scratch now.