ARGBToYUY2 failure on odd width

[GoogleCodeExporter]

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] libyuvTest.ARGBToYUY2_Random
[  FAILED  ] libyuvTest.ARGBToUYVY_Random

Original issue reported on code.google.com by fbarch...@chromium.org on 12 Jun 2015 at 6:55

[GoogleCodeExporter]

set LIBYUV_WIDTH=123
out\release\libyuv_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*

[==========] 798 tests from 1 test case ran. (6647 ms total)
[  PASSED  ] 774 tests.
[  FAILED  ] 24 tests, listed below:
[  FAILED  ] libyuvTest.I420ToYUY2_Any
[  FAILED  ] libyuvTest.I420ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I420ToYUY2_Invert
[  FAILED  ] libyuvTest.I420ToYUY2_Opt
[  FAILED  ] libyuvTest.I420ToUYVY_Any
[  FAILED  ] libyuvTest.I420ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I420ToUYVY_Invert
[  FAILED  ] libyuvTest.I420ToUYVY_Opt
[  FAILED  ] libyuvTest.I422ToYUY2_Any
[  FAILED  ] libyuvTest.I422ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I422ToYUY2_Invert
[  FAILED  ] libyuvTest.I422ToYUY2_Opt
[  FAILED  ] libyuvTest.I422ToUYVY_Any
[  FAILED  ] libyuvTest.I422ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I422ToUYVY_Invert
[  FAILED  ] libyuvTest.I422ToUYVY_Opt
[  FAILED  ] libyuvTest.ARGBToYUY2_Any
[  FAILED  ] libyuvTest.ARGBToYUY2_Unaligned
[  FAILED  ] libyuvTest.ARGBToYUY2_Invert
[  FAILED  ] libyuvTest.ARGBToYUY2_Opt
[  FAILED  ] libyuvTest.ARGBToUYVY_Any
[  FAILED  ] libyuvTest.ARGBToUYVY_Unaligned
[  FAILED  ] libyuvTest.ARGBToUYVY_Invert
[  FAILED  ] libyuvTest.ARGBToUYVY_Opt

24 FAILED TESTS
  YOU HAVE 73 DISABLED TESTS

Original comment by fbarch...@chromium.org on 15 Jun 2015 at 6:48

[GoogleCodeExporter]

[  PASSED  ] 769 tests.
[  FAILED  ] 29 tests, listed below:
[  FAILED  ] libyuvTest.I420ToYUY2_Any
[  FAILED  ] libyuvTest.I420ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I420ToYUY2_Invert
[  FAILED  ] libyuvTest.I420ToYUY2_Opt
[  FAILED  ] libyuvTest.I420ToUYVY_Any
[  FAILED  ] libyuvTest.I420ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I420ToUYVY_Invert
[  FAILED  ] libyuvTest.I420ToUYVY_Opt
[  FAILED  ] libyuvTest.I422ToYUY2_Any
[  FAILED  ] libyuvTest.I422ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I422ToYUY2_Invert
[  FAILED  ] libyuvTest.I422ToYUY2_Opt
[  FAILED  ] libyuvTest.I422ToUYVY_Any
[  FAILED  ] libyuvTest.I422ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I422ToUYVY_Invert
[  FAILED  ] libyuvTest.I422ToUYVY_Opt
[  FAILED  ] libyuvTest.ARGBToYUY2_Any
[  FAILED  ] libyuvTest.ARGBToYUY2_Unaligned
[  FAILED  ] libyuvTest.ARGBToYUY2_Invert
[  FAILED  ] libyuvTest.ARGBToYUY2_Opt
[  FAILED  ] libyuvTest.ARGBToYUY2_Random
[  FAILED  ] libyuvTest.ARGBToUYVY_Any
[  FAILED  ] libyuvTest.ARGBToUYVY_Unaligned
[  FAILED  ] libyuvTest.ARGBToUYVY_Invert
[  FAILED  ] libyuvTest.ARGBToUYVY_Opt
[  FAILED  ] libyuvTest.ARGBToUYVY_Random
[  FAILED  ] libyuvTest.ARGBMultiply_Invert
[  FAILED  ] libyuvTest.ARGBSubtract_Invert
[  FAILED  ] libyuvTest.TestVersion

29 FAILED TESTS

Original comment by fbarch...@chromium.org on 15 Jun 2015 at 7:06

• Changed state: Started

[GoogleCodeExporter]

[  FAILED  ] 21 tests, listed below:
[  FAILED  ] libyuvTest.I420ToYUY2_Any
[  FAILED  ] libyuvTest.I420ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I420ToYUY2_Invert
[  FAILED  ] libyuvTest.I420ToYUY2_Opt
[  FAILED  ] libyuvTest.I420ToUYVY_Any
[  FAILED  ] libyuvTest.I420ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I420ToUYVY_Invert
[  FAILED  ] libyuvTest.I420ToUYVY_Opt
[  FAILED  ] libyuvTest.I422ToYUY2_Any
[  FAILED  ] libyuvTest.I422ToYUY2_Unaligned
[  FAILED  ] libyuvTest.I422ToYUY2_Invert
[  FAILED  ] libyuvTest.I422ToYUY2_Opt
[  FAILED  ] libyuvTest.I422ToUYVY_Any
[  FAILED  ] libyuvTest.I422ToUYVY_Unaligned
[  FAILED  ] libyuvTest.I422ToUYVY_Invert
[  FAILED  ] libyuvTest.I422ToUYVY_Opt
[  FAILED  ] libyuvTest.ARGBToUYVY_Any
[  FAILED  ] libyuvTest.ARGBToUYVY_Unaligned
[  FAILED  ] libyuvTest.ARGBToUYVY_Invert
[  FAILED  ] libyuvTest.ARGBToUYVY_Opt
[  FAILED  ] libyuvTest.ARGBToUYVY_Random

21 FAILED TESTS

Original comment by fbarch...@chromium.org on 16 Jun 2015 at 5:46

[GoogleCodeExporter]

Fixed with https://webrtc-codereview.appspot.com/50249004

Original comment by fbarch...@google.com on 16 Jun 2015 at 11:31

• Changed state: Fixed

[GoogleCodeExporter]

also dr memory complains
Error #1: UNINITIALIZED READ: reading 0x0018fc74-0x0018fc78 4 byte(s) within 
0x0018fc70-0x0018fc78
# 0 I422ToYUY2Row_SSE2                                                         
[d:\src\libyuv\libyuv\source\row_win.cc:6069]
# 1 I422ToYUY2Row_Any_SSE2                                                     
[d:\src\libyuv\libyuv\source\row_any.cc:65]
# 2 I422ToYUY2                                                                 
[d:\src\libyuv\libyuv\source\convert_from.cc:193]
# 3 libyuv::libyuvTest_I422ToYUY2_Any_Test::TestBody                           
[d:\src\libyuv\libyuv\unit_test\convert_test.cc:512]
# 4 testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> 
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:2420]
# 5 testing::Test::Run                                                         
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:2437]
# 6 testing::TestInfo::Run                                                     
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:2612]
# 7 testing::TestCase::Run                                                     
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:2730]
# 8 testing::internal::UnitTestImpl::RunAllTests                               
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:4604]
# 9 
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTe
stImpl,bool> [d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:2420]
#10 testing::UnitTest::Run                                                     
[d:\src\libyuv\libyuv\testing\gtest\src\gtest.cc:4225]
#11 RUN_ALL_TESTS                                                              
[d:\src\libyuv\libyuv\testing\gtest\include\gtest\gtest.h:2326]
Note: @0:00:03.433 in thread 1180
Note: instruction: movq   (%esi) -> %xmm2

Original comment by fbarch...@google.com on 17 Jun 2015 at 11:28