MilkBowl / LocalShops

A Shop plugin for Bukkit (Minecraft Server)
http://forums.bukkit.org/threads/17131/
GNU General Public License v2.0
8 stars 4 forks source link

LocalShops hangs server when unloaded and reloaded using Plugman #1

Closed grandwazir closed 13 years ago

grandwazir commented 13 years ago

Pretty much as the title. I am testing using a bash script to revert shops to a template at specified intervals. This is to simulate shops restocking in our roleplay world.

Part of the script disables LocalShops, copies the shop template to /shops then enables LocalShops again which should work without a hitch.

What actually happens is that while LocalShops disables fine, loading it again causes the server to stop responding until it is killed. Nothing appears in the log except for multiple 'read timed out' which is typical when a server stops responding.

I suppose I could use the built in reload command instead to reload all the plugins when I do this but the behaviour still bugs me. Is there any reason why I am encountering this behaviour?

grandwazir commented 13 years ago

Actually thinking about this prehaps a better way around it would be to add a reload command to LocalShops itself to avoid needing to disable it in the first place to reload shop data.

Sleaker commented 13 years ago

sounds like an issue with your server. mine doesn't hang while using disable/enable. As a sidenote, localshops is built to not allow data to be edited via the config files because they are persistent elements.

I do have plans to implement auto-restocking/market stock fluctuations.

grandwazir commented 13 years ago

For the meantime though I assume it should still work if I disable the plugin then edit the configuration files?

Oh and I will try doing the same with only LocalShops and plugman and see if it still happens when I get a chance.

Sleaker commented 13 years ago

This issue is confirmed, server process does a full lock in the dev version when being disabled / enabled via PlugMan - unsure of why this is happening, it may be something to do with how plugman handles the plugin disabling? reloading works fine - usually.

grandwazir commented 13 years ago

It is odd. I am getting around it for my purposes by disabling LocalShops then doing 'reload' which does work without hanging the server.

It might be a Bukkit issue, other plugins do weird things too. Big Brother logs everything twice for example when reloaded. Stargate doesn't work. LWC plays up sometimes as well.

Sleaker commented 13 years ago

yah relaod can be finicky, but localshops reloads just fine, it's just it doesn't work with plugman apparently.

cerealcable commented 13 years ago

Can a complete server.log (with LocalShops debugging enabled) file be attached here so I can see what is happening? FYI: Debugging variable is set in the properties file.

Sleaker commented 13 years ago

Going to chock this up as an incompatibility with how bukkit stores the classes in memory and how the plugin manager handles disabling/renabling plugins.

grandwazir commented 13 years ago

I would upload a log but with those settings enabled nothing appears in the log at all after you issue the reload command.