Specialize EssentialsX economy to support UUID based lookup

MilkBowl / Vault

Vault of common APIs for Bukkit Plugins

GNU Lesser General Public License v3.0

496 stars 354 forks source link

Specialize EssentialsX economy to support UUID based lookup #830

Closed RickyB98 closed 3 years ago

RickyB98 commented 4 years ago

This pull request continues to support the normal Essentials plugin, as well as support the UUID based lookup implemented in EssentialsX. This avoids redundant name to UUID resolutions in case the developer uses the methods with OfflinePlayer. Backwards compatibility is preserved for plugins using the String methods. Uses latest EssentialsX.

RickyB98 commented 4 years ago

Looks like the Travis check fails due to a failed deploy, although that shouldn't happen since it's a pull request. I'll leave that to someone else.

Sleaker commented 3 years ago

This is a great candidate and time for EssentialsX to start handling and maintaining it's own hook in it's own source tree.

RickyB98 commented 3 years ago

And why would EssentialsX be different from all the other plugins whose hooks you do maintain in this source tree?

Sleaker commented 3 years ago

@RickyB98 I no longer maintain hooks or add new hooks in Vault. the remaining ones are for legacy purposes only. I also never added an EssentialsX plugin hook.